Skip to content

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Apr 1, 2025

Description

Added optional list of interfaces to skip in interfaces in following testcases:

  1. VerifyInterfaceUtilization
  2. VerifyInterfaceDiscards
  3. VerifyPortChannels
  4. VerifyIllegalLACP
  5. VerifyInterfaceErrors

Fixes #1124

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #1132 will create unknown performance changes

Comparing geetanjalimanegslab:issue_1124_interface_test (396661d) with main (7ac2623)

Summary

🆕 22 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_anta[1-device] N/A 1.2 s N/A
🆕 test_anta[2-devices] N/A 2.5 s N/A
🆕 test_anta_dry_run[1-device] N/A 67.4 ms N/A
🆕 test_anta_dry_run[2-devices] N/A 110.9 ms N/A
🆕 test_csv[1-device] N/A 21.6 ms N/A
🆕 test_csv[2-devices] N/A 42.8 ms N/A
🆕 test_jinja[1-device] N/A 64.7 ms N/A
🆕 test_jinja[2-devices] N/A 124.7 ms N/A
🆕 test_json[1-device] N/A 43.1 ms N/A
🆕 test_json[2-devices] N/A 85.4 ms N/A
🆕 test_markdown[1-device] N/A 10.8 ms N/A
🆕 test_markdown[2-devices] N/A 20.8 ms N/A
🆕 test_table_all[1-device] N/A 21.2 ms N/A
🆕 test_table_all[2-devices] N/A 42.4 ms N/A
🆕 test_table_devices[1-device] N/A 280.4 µs N/A
🆕 test_table_devices[2-devices] N/A 309.3 µs N/A
🆕 test_table_tests[1-device] N/A 3.4 ms N/A
🆕 test_table_tests[2-devices] N/A 3.5 ms N/A
🆕 test_get_coroutines[1-device] N/A 42.6 ms N/A
🆕 test_get_coroutines[2-devices] N/A 84.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@geetanjalimanegslab geetanjalimanegslab marked this pull request as ready for review April 10, 2025 08:52
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review on #1145 and align this PR with it. Thanks!

@carl-baillargeon
Copy link
Contributor

@geetanjalimanegslab Can we also add VerifyInterfaceErrors to this PR please?

Thanks

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-baillargeon carl-baillargeon merged commit 7ac2623 into aristanetworks:main May 12, 2025
12 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(anta.tests): Add optional list of interfaces to skip in interfaces tests
3 participants