Skip to content

Conversation

carl-baillargeon
Copy link
Contributor

Description

get_json_results function in ResultManager was serializing None objects to 'None' instead of null.

It will now use the built-in model_dump from Pydantic for proper serialization.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@carl-baillargeon carl-baillargeon requested review from gmuloc and mtache and removed request for gmuloc January 17, 2024 15:52
Copy link
Collaborator

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 7669366 into aristanetworks:main Feb 5, 2024
@carl-baillargeon carl-baillargeon deleted the fix/get_json_results branch May 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants