Skip to content

feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide (error|failure|success|skipped) to hide results. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 29, 2024
Merged

feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide (error|failure|success|skipped) to hide results. #588

merged 31 commits into from
Mar 29, 2024

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Mar 18, 2024 •
edited by mtache
Loading

Description

Implement some cli enhancements:

  • Add --device and --test to anta nrfu to filter by tests or devices. Can be used multiple times.
  • Honor device and test filters at runner level: no undesired API calls are done towards devices
  • Implement --hide (error|failure|success|skipped) to anta nrfu hide test in results

Fixes #585

Example with device and test

image

Example of skip-error,failure,success

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

mtache
mtache requested changes Mar 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@titom73 titom73 requested a review from mtache March 20, 2024 14:58
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 marked this pull request as ready for review March 20, 2024 15:02
@titom73 titom73 added framework-enhancement New feature or request Anta CLI All things around CLI labels Mar 20, 2024
@gmuloc gmuloc added this to the v1.0.0 milestone Mar 22, 2024
gmuloc
gmuloc reviewed Mar 25, 2024
View reviewed changes
gmuloc
gmuloc reviewed Mar 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc
gmuloc reviewed Mar 28, 2024
View reviewed changes
This was linked to issues Mar 28, 2024
Change --device and --test behavior to avoid running all tests #406
Closed
Add a --device option to anta nrfu to run tests on specific devices of the inventory #555
Closed
@mtache mtache changed the title feat(anta.cli): Make anta nrfu CLI more consistent feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide(error|failure|success) to hide results. Mar 28, 2024
gmuloc
gmuloc reviewed Mar 29, 2024
View reviewed changes
gmuloc
gmuloc requested changes Mar 29, 2024
View reviewed changes
@mtache mtache changed the title feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide(error|failure|success) to hide results. feat(anta.cli): anta nrfu enchancements: add --device and --test to filter tests and --hide (error|failure|success|skipped) to hide results. Mar 29, 2024
titom73 and others added 26 commits March 29, 2024 13:21
@titom73 @mtache
doc: Update NRFU documentation
168b392
@titom73 @mtache
feat(anta): Move device filtering at inventory level and not in runner
3c1c9e7
@titom73 @mtache
feat(anta): Add support for devices list in AntaInventory get_inventory
171d782
@titom73 @mtache
feat(anta): Move test filtering at catalog level and not in runner
e0f2dbc
@titom73 @mtache
fix(anta.cli): Fix some CLI description as per PR review
4a14738
@titom73 @mtache
ci: Fix unit test for reporter
9558e16
@mtache
Linting
6dc5ab1
@mtache
Do not ignore TRY004 globally
9dbbeea
@mtache
feat: support multiple devices and tests as filter
019104e
@mtache
Adressing comments
213c973
@mtache
fix linting
5d606a7
@mtache
refactor: ResultManager and anta.reporter
104f86a
@mtache
feat: move hide flags to anta nrfu
bad5506
@mtache
update unit tests
c791147
@mtache
rename add_test_result to add
ce55e75
@mtache
use --hide Literal instead of flags
386c65b
@mtache
Addressing comments
40d6a60
@mtache
test: add unit tests for result_manager
d5dbd62
@mtache
test: fix unit tests
fa0db1d
@mtache
Addressing comments
752ed7f
@mtache
refactor: anta.tools
2a5950b
@mtache
add set types where it makes sense
f797399
@mtache
fix typing
7ddeb8d
@mtache
fix typing
23aa4a6
@mtache
fix typing
1688fc6
@mtache
fix unit tests
a165268
@mtache mtache merged commit b2dadb1 into aristanetworks:main Mar 29, 2024
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc requested changes

@mtache mtache mtache approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@titom73 titom73

Labels
Anta CLI All things around CLI framework-enhancement New feature or request rn: feat(anta.cli)
Projects
None yet
Milestone
v1.0.0
3 participants
@titom73 @mtache @gmuloc