Skip to content

doc: Nicer FAQ #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

doc: Nicer FAQ #596

merged 1 commit into from
Mar 21, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Mar 20, 2024

Description

Some more mkdocs tricks

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.0.0 milestone Mar 20, 2024
@titom73 titom73 self-requested a review March 21, 2024 08:05
titom73
titom73 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ship it ! 🚢
(I would make all the entries open by default but it is a detail)

@titom73 titom73 added the documentation Improvements or additions to documentation label Mar 21, 2024
carl-baillargeon
carl-baillargeon approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit f1beef2 into aristanetworks:main Mar 21, 2024
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

+1 more reviewer

@titom73 titom73 titom73 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gmuloc gmuloc

Labels
documentation Improvements or additions to documentation rn: doc
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @titom73 @carl-baillargeon