Skip to content

fix: Add missing testcases in example folder #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2024
Merged

fix: Add missing testcases in example folder #749

merged 5 commits into from
Jul 8, 2024

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Jul 7, 2024 •
edited
Loading

Description

  • fix: Add missing testcases for ISIS in example folder
  • fix: Add missing testcases for anta.tests.configuration.VerifyRunningConfigLines in example folder
  • doc: Update example README with missing files

Fixes #743

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@titom73 titom73 requested review from mtache and carl-baillargeon and removed request for mtache July 7, 2024 13:10
@titom73 titom73 added the documentation Improvements or additions to documentation label Jul 7, 2024
@titom73 titom73 added this to the v1.1.0 milestone Jul 7, 2024
gmuloc
gmuloc reviewed Jul 8, 2024
View reviewed changes
gmuloc
gmuloc approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@titom73 titom73 merged commit e8e2038 into aristanetworks:main Jul 8, 2024
@titom73 titom73 deleted the fix/743-add-isis-testcases branch July 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

@mtache mtache Awaiting requested review from mtache

Assignees

@titom73 titom73

Labels
documentation Improvements or additions to documentation rn: fix
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Add missing tests to examples/tests.yaml
2 participants
@titom73 @gmuloc