Skip to content

Conversation

carl-baillargeon
Copy link
Contributor

Description

When using the CLI command anta nrfu json --output ./results.json, results will be saved in a JSON file without printing to the console.

Fixes #760

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maybe need to mark the PR as a breaking change?

@carl-baillargeon
Copy link
Contributor Author

LGTM - maybe need to mark the PR as a breaking change?

Not sure.. The basic usage without --output remains unchanged and the new bahavior is more consistent with common CLI patterns (where specifying an output file often implies redirecting output away from stdout) so it could be considered as a fix/bug.

Copy link

@carl-baillargeon carl-baillargeon merged commit 90299d1 into aristanetworks:main Aug 28, 2024
19 checks passed
@carl-baillargeon carl-baillargeon deleted the fix/issue-760 branch March 16, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using anta nrfu json --output results.json we shouldn't have the results on the console
2 participants