Skip to content

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 4, 2024

Description

ANTA should not configure the devices - only outputing a nice error message when something is missing

Fixes #894

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #913 will not alter performance

Comparing gmuloc:issue/894 (d537c0c) with main (6414404)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally:
image

Copy link

sonarqubecloud bot commented Nov 5, 2024

@carl-baillargeon carl-baillargeon merged commit 595790f into aristanetworks:main Nov 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate AAA configuration show collect show-tech
2 participants