Skip to content

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Refactoring security tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #957 will not alter performance

Comparing vitthalmagadum:feat/security_ssl (e999930) with main (e82c1a5)

Summary

✅ 22 untouched benchmarks

Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for coverage

Screenshot 2024-12-12 at 10 38 51

gmuloc
gmuloc previously requested changes Dec 18, 2024
@gmuloc gmuloc added this to the v1.3.0 milestone Dec 24, 2024
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

Copy link

@gmuloc gmuloc dismissed their stale review January 15, 2025 14:49

comments addressed

@gmuloc gmuloc merged commit d57b53e into aristanetworks:main Jan 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants