Skip to content

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Dec 23, 2024

Description

Use correct type for inputs

Fixes #973

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #977 will not alter performance

Comparing gmuloc:issue/973 (1d5d33f) with main (5afc61d)

Summary

✅ 22 untouched benchmarks

@gmuloc gmuloc added this to the v1.2.0 milestone Dec 23, 2024
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 4e13729 into aristanetworks:main Dec 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: VerifyInterfaceIPv4 seems to use wrong type for IPv4 Addresses
2 participants