Add compilation services to container in MvcRazorMvcCoreBuilderExtensions

[davidfowl]

Mvc/src/Microsoft.AspNet.Mvc.Razor/DependencyInjection/MvcRazorMvcCoreBuilderExtensions.cs

Line 118 in 9342cb0

internal static void AddRazorViewEngineServices(IServiceCollection services)

Hosting shouldn't be adding these. It should be added by MvcRazorMvcCoreBuilderExtensions if those services are available.

/cc @pranavkm @NTaylorMullen

This is to react to aspnet/Hosting#438

[pranavkm]

What does Razor do if the services aren't available: CompilationServices.Default is null

[davidfowl]

Don't add them to the container and there'll be a regular DI error.

[rynowak]

That seems like a less than optimal dev experience... what are the conditions where that could arise?

[davidfowl]

that is how most of mvc works today and most of the other frameworks. TryAdd things that it needs, this is no different. If we don't have a default implementation one must be provided. It's possible to conjure these up from nowhere but we can do that later.

As for your original question, the only way it can happen is if a user does something weird like overwrite the default platform services.

[rynowak]

As for your original question, the only way it can happen is if a user does something weird like overwrite the default platform services.

OK then I have no concerns about this 😀