Support localizing [DisplayAttribute] via IStringLocalizer

[NTaylorMullen]

Today we only localize validation based data annotations. We should expand this outside of the realm of validation (especially since you do a services.AddDataAnnotationsLocalization which says nothing about only adding validation based data annotations.

Having support like this would enable scenarios such as:

Model:

public class User
{
    [Display(Name = "Last Name")]
    public string LastName { get; set; }
}

Page

@model User
@addTagHelper *, Microsoft.AspNet.Mvc.TagHelpers

<label asp-for="LastName" /> <!-- Label would be localizable -->

This issue is for more than just [Display] but this data annotation is the one that showed itself during my sign off activities.

[DamianEdwards]

I agree this is something we should investigate. I imagine we'd do the work in DataAnnotationsMetadataProvider to support this.

[hishamco]

Can we extend DataAnnotationsModelMetadataProvider to make this happen, code snippet may look like this

public class LocalizedDataAnnotationsModelMetadataProvider: DataAnnotationsModelMetadataProvider
{
    protected override ModelMetadata CreateMetadata(IEnumerable<Attribute> attributes, Type containerType, Func<object> modelAccessor, Type modelType, string propertyName)
    {
        var meta = base.CreateMetadata(attributes, containerType, modelAccessor, modelType, propertyName);
        meta.DisplayName = Localizer[propertyName];
    }
}

[DamianEdwards]

At this stage this is extremely unlikely to make it into 1.0.0, but we'll revisit it after we release.

[hishamco]

I'm agree with you, this may be move to the backlog, because it need more investigation ..