feat: Introduce validatePassword, getIdentifiers and getActiveIdentifiers helper methods #155
+232
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re for validatePassword utility hook
nandan-bhat
requested changes
Aug 28, 2025
| * Type guard to ensure connection is of type DBConnection. | ||
| */ | ||
| function isDBConnection(conn: unknown): conn is DBConnection { | ||
| return typeof conn === 'object' && conn !== null && 'options' in conn; |
There was a problem hiding this comment.
This would return true for PasswordlessConnection as-well.
nandan-bhat
requested changes
Aug 28, 2025
| } | ||
| } | ||
|
|
||
| return activeIdentifiers; |
There was a problem hiding this comment.
We have the following implementation which would work for password-less flow as well.
The current implementation covers only username-password flow.
nandan-bhat
requested changes
Aug 28, 2025
| */ | ||
| function getIdentifier(): Identifier[] { | ||
| const context = new BaseContext(); | ||
| const transactionContext = context.getContext('transaction'); |
There was a problem hiding this comment.
Why are we using getContext here ?
Can't we implement it similar to validatePassword ?
| import type { PasswordValidationResult } from '../../interfaces/models/screen'; | ||
| import type { PasswordPolicy, Error, PasswordComplexityRule } from '../../interfaces/models/transaction'; | ||
|
|
||
| function validatePassword( |
There was a problem hiding this comment.
Unit test is missing for this implementation.
ankita10119
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new utility hooks to support reusable logic in form validation and identifier handling across screens:
🔧 Changes Introduced:
usePasswordValidation:
Validates password input against the current passwordPolicy from context.
Helps prevent network requests when client-side password validation fails.
useIdentifiers:
Provides a unified list of required and optional identifiers (email, phone, username) based on the current transaction context.
Enables dynamic rendering of identifier fields in forms.
useActiveIdentifiers:
Provides a list of identifiers the user can use for sign-in. This hook can be used in login-id and login screens.
Enables dynamic rendering of identifier fields in forms.
🎯 Purpose:
Centralizes password validation logic to ensure consistency across screens.
Improves form rendering flexibility based on identifier configuration.
Avoids direct use of transaction.errors for pre-submit validations.
🧪 Screens Affected:
References
Testing
Tested and validated these changes with sample react app via universal-login-samples screen examples.
Checklist