Implementation: Utility function startMfaPushPolling #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandan-bhat
requested changes
Aug 26, 2025
| @@ -0,0 +1,57 @@ | |||
| # MFA Push Polling Utility | |||
|
|
|||
| This utility provides robust polling for MFA push notifications in React applications. It ensures a push request is sent immediately and then at a specified interval, until the polling is cancelled (e.g., on component unmount or dependency change). | |||
There was a problem hiding this comment.
Why do we have this .MD file isnide helpers folder ? This should be inside examples folder.
| * @param transaction Instance of MfaPushChallengePush | ||
| * @returns cancel function to stop polling | ||
| */ | ||
| export function startMfaPushPolling( |
There was a problem hiding this comment.
This implementation is not correct. The example we have on the RFC is outdated and we have explicitly called it out.
There's a note in the RFC regarding how it should be implemented.
There was a problem hiding this comment.
I have push the changes following the implementation needed.Please review @nandan-bhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
startMfaPushPollingutility function to the auth0-acul-js package.The function enables polling for MFA push challenge approval at a user-defined interval, using an instance of MfaPushChallengePush.
It simplifies the process of repeatedly sending push requests until cancelled, without requiring a maximum attempts parameter.
Added startMfaPushPolling implementation in src/helpers/startMfaPushPolling.ts
Exported the function from the package entry point (index.ts)
Allows consumers to easily start and stop polling for MFA push challenges in their applications