Skip to content

Conversation

zanesq
Copy link
Collaborator

@zanesq zanesq commented Aug 21, 2025

Improves the scrolling behavior during chat to stop auto scrolling to the bottom after an agent response. Also lets the scroll area handle scrolling to bottom rather than the message list.

Also potentially fixes the occasional jumpiness when the agent is responding since its no longer fighting various scroll to bottom mechanisms.

@zanesq zanesq requested a review from alexhancock August 21, 2025 19:22
Copy link
Collaborator

@amed-xyz amed-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zanesq zanesq mentioned this pull request Aug 21, 2025
Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! this has been an issue recently and just from reading the code I think this will be better.

@michaelneale
Copy link
Collaborator

nice, much tidier code too!

@zanesq zanesq merged commit 69ad4ca into main Aug 22, 2025
11 checks passed
@zanesq zanesq deleted the zane/adjust-auto-scrolling branch August 22, 2025 14:15
@alexhancock alexhancock mentioned this pull request Aug 22, 2025
michaelneale added a commit that referenced this pull request Aug 24, 2025
* main:
  docs: Plan tutorial (#4309)
  Extensions Modal Improvements (#4293)
  docs: fixed cicd tutorial pipeline in docs (#4223)
  Read oltp config from config and env (#4292)
  release/1.6.0 (#4280)
  docs: fix broken links in Docker tutorial (#4285)
  Remove half-second wait, rework auto submit (#4282)
  Block send until extensions are ready (#4271)
  fix: improve OpenAI-compatible error handling and add test coverage (#4175)
  Move To-Do Tool to Session Scope from Agent Scope (#4157)
  fix: recipe params not being replaced all the time (#4207)
  chore: removing little-used session sharing feature (#4249)
  Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257)
  restore cli projects from accidental removal during cleanup (#4266)
  Fix: deep link extension installation to show dialog for headers configuration (#4150)
michaelneale added a commit that referenced this pull request Aug 25, 2025
* main: (24 commits)
  feat: autovisualiser of structured data with mcp-ui (#4153)
  docs: Plan tutorial (#4309)
  Extensions Modal Improvements (#4293)
  docs: fixed cicd tutorial pipeline in docs (#4223)
  Read oltp config from config and env (#4292)
  release/1.6.0 (#4280)
  docs: fix broken links in Docker tutorial (#4285)
  Remove half-second wait, rework auto submit (#4282)
  Block send until extensions are ready (#4271)
  fix: improve OpenAI-compatible error handling and add test coverage (#4175)
  Move To-Do Tool to Session Scope from Agent Scope (#4157)
  fix: recipe params not being replaced all the time (#4207)
  chore: removing little-used session sharing feature (#4249)
  Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257)
  restore cli projects from accidental removal during cleanup (#4266)
  Fix: deep link extension installation to show dialog for headers configuration (#4150)
  feat: Add message queue system with interruption handling (#4179)
  Start extensions concurrently  (#4234)
  Add X-Title and referer headers on exchange to tetrate (#4250)
  docs: update View/Edit Recipe menu item name (#4267)
  ...
shellz-n-stuff pushed a commit to shellz-n-stuff/goose that referenced this pull request Aug 27, 2025
…rolling to bottom (block#4257)

Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants