Support content providers for import and exports #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually the importer and exporter will need to support content Uri's so the file argument will not make sense. The caller should know what was imported and exported, so moving that logic to the calling activity.
Starting in Android 7+ passing file Uris to other activities is discouraged or prevented. To allow exporting to work correctly, a FileProvider is now used to pass backups to other activities. For imports both file Uris and content Uris are now supported.
On Android 7 it was found that the share button on the receipt sharing activity was missing, because ProGuard removed a needed class. This may not have been caught when ProGuard was enabled, or it may have been a changing requirement in Android 7. Either way, ProGuard has caused a few issues thus far with minimal benefit.
Starting in Android 24 file Uris cannot be used outside of an Activity. To allow images to be captured with a camera, a content Uri needs to be used. This change will use a FileProvider on Android 24+. For earlier versions the file Uri will still be used. This provides backwards compatability, as well as allows Robolectric to continue to test the general code path.
Previously backups were being reported as "text/plain", which for CSV and JSON was not incorrect but it could have been more specific, and for ZIP was incorrect. Now the correct mime type will be used when sending data to other activities.
This was added to prevent Android 7+ from complaining when a file:// Uri is shared with another Activity. This did not work on all Android devices that enforced not sharing file:// Uris. The issues have been resolved so this is no longer needed.
brarcher
force-pushed
the
content-provider
branch
from
a191928 to
b038fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.