Skip to content

Conversation

mrgreekgeek
Copy link
Contributor

@normansimonr here's a request to update the Stephens text to also have Unicode files available.

@mrgreekgeek
Copy link
Contributor Author

@normansimonr I just realized that MT.STV is different, and has some extra newlines (which leaves an extraneous newline in the resultant Unicode file). Should the file be fixed, or shall I adjust my script to compensate?

@normansimonr
Copy link
Collaborator

Hi @mrgreekgeek thanks so much for this contribution! I will probably have some time to review it in one or two weeks, but to answer your question, we can't change the source files unless requested by Professor Robinson, so adjusting the script would the the best course of action. Thanks!

@mrgreekgeek
Copy link
Contributor Author

It's a pleasure, @normansimonr! I just updated the script with a few little tweaks. Do I need to re-upload the resultant unicode files as well, or will you be re-generating them anyway?

@normansimonr
Copy link
Collaborator

@mrgreekgeek Brilliant, thank you so much! Yes, please, commit the Unicode files as well. That way I can verify both your script and the output.

Thanks!

@mrgreekgeek
Copy link
Contributor Author

@normansimonr My pleasure! I've updated the files.

@normansimonr
Copy link
Collaborator

I've checked the generated files and in general they seem to have been converted correctly. I wasn't able to detect any systematic conversion errors to the best of my ability.

Thank you very much @mrgreekgeek for this great contribution!

@normansimonr normansimonr merged commit f7f71ad into byztxt:master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants