checkcondition.cpp: fixed -Wbitwise-instead-of-logical Clang warnings
#7736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/checkcondition.cpp
Outdated
| @@ -78,6 +78,13 @@ bool CheckCondition::diag(const Token* tok, bool insert) | |||
| return true; | |||
| } | |||
|
|
|||
| bool CheckCondition::diag(const Token* tok1, const Token* tok2) | |||
| { | |||
| bool b = diag(tok1); | |||
There was a problem hiding this comment.
Maybe spell out the logic in a comment? We always mark both tokens as diagnosed.
Could also use two variables: return b1 && b2;
There was a problem hiding this comment.
Maybe spell out the logic in a comment?
I never understood the logic. Care to provide a comment to add?
There was a problem hiding this comment.
diag(tok) marks a token as diagnosed and returns true if it was already marked. diag(tok1, tok2) therefore needs to mark both tokens. // mark both tokens would probably be enough.
these are shown with a make build using Clang
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are shown with a make build using Clang