Skip to content

Untracked Dependancy on pywinrm #36

@thebeanogamer

Description

@thebeanogamer

QwikContext

omsdk.http.sdkwmi requires winrm to function, but it is not in requirements.txt

Details

omsdk.http.sdkwmi imports functions from the winrm module, but this dependency is not expressed anywhere. That means that anyone installing this module from PyPi will get an error if they try and use that class. Given that Ansible also uses pywinrm (https://docs.ansible.com/ansible/latest/os_guide/windows_winrm.html#what-is-winrm), I'm guessing that this was missed by accident as it was already installed.

Repro Steps

  1. pip install omsdk
  2. Import omsdk.http.sdkwmi in a Python file.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.12/site-packages/omsdk/http/sdkwmi.py", line 25, in <module>
    from winrm.transport import Transport
ModuleNotFoundError: No module named 'winrm'

Impact

Error when using omsdk.http.sdkwmi until user manually runs pip install pywinrm.

NeedBy

Whenever convenient.

Severity

Low.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions