Skip to content

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Aug 13, 2025

This PR bumps the versions of @std/expect and @std/assert to ensure the fix #6747 is applied to the users of those packages.

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (908dcb0) to head (7855b8c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6791   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         590      590           
  Lines       42577    42577           
  Branches     6718     6718           
=======================================
  Hits        40107    40107           
  Misses       2421     2421           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k requested review from crowlKats and bartlomieju August 13, 2025 07:05
@kt3k
Copy link
Member Author

kt3k commented Aug 13, 2025

For more context: The fix #6747 is already published as @std/internal@1.0.10, but because @std/assert and @std/expect is not released after that, there's no obvious way to update @std/internal to the latest when the old version of @std/internal is stored in their lock file. This PR bumps the versions of these 2 packages, which provides the obvious way to upgrade @std/internal to the latest.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a reason this is done manually instead of automated script?

@kt3k
Copy link
Member Author

kt3k commented Aug 13, 2025

@bartlomieju The automated script only detects the direct changes in that package. The fix #6747 was done only in @std/internal indirectly, and @std/assert and @std/expect were not updated automatically..

(Maybe we should consider updating the dependent packages as well in such situation..)

@kt3k kt3k merged commit 40d6cac into denoland:main Aug 13, 2025
19 checks passed
@kt3k kt3k deleted the bump-assert-and-expect branch August 13, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants