Skip to content

Conversation

BlackAsLight
Copy link
Contributor

#6783 should be merged before this one.

This pull request rewrites the tests for TarStream to not only be more concise, but to also test for more behaviour than before and now offers 100% coverage.

@BlackAsLight BlackAsLight requested a review from kt3k as a code owner August 13, 2025 07:22
@github-actions github-actions bot added the tar label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (840057c) to head (4c612d5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6793   +/-   ##
=======================================
  Coverage   94.19%   94.20%           
=======================================
  Files         590      590           
  Lines       42649    42649           
  Branches     6726     6730    +4     
=======================================
+ Hits        40174    40177    +3     
+ Misses       2426     2421    -5     
- Partials       49       51    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title refactor(tar): TarStream's tests test(tar): improve TarStream's tests Aug 25, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 42fd485 into denoland:main Aug 25, 2025
20 checks passed
@BlackAsLight BlackAsLight deleted the tar_refactor_tests branch August 25, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants