Skip to content

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Jul 14, 2023

This PR make a few things:

  • Focus the last focused element when the list is unmounted
  • Return focus back to last focused element when tabbing forward out of list
  • Show close button when toast is focused
2023-07-14.15-56-11.mp4
2023-07-14.15-56-46.mp4

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 10:14pm

@emilkowalski
Copy link
Owner

This is awesome, can we perhaps write some tests as well?

@joaom00
Copy link
Contributor Author

joaom00 commented Jul 14, 2023

Yeah, I tried to add it but for some reason I can't move the focus to Toast or some button inside it. Do you know what could be happening? I will try again

@joaom00
Copy link
Contributor Author

joaom00 commented Jul 14, 2023

@emilkowalski done

@emilkowalski emilkowalski merged commit 2f6b2b9 into emilkowalski:main Jul 15, 2023
@joaom00 joaom00 deleted the focus branch July 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants