Update Supported Kubernetes to 1.29, 1.30, 1.31 #4024

kamaljeeti · 2024-10-28T10:57:18Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#4018

working on #4018

Special notes for your reviewer:

github-actions · 2024-10-28T10:57:35Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-28T11:35:39Z

Build Failed 😭

Build Id: 1803aad5-0227-4b7b-8637-2fd8dd48cf50

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-28T12:46:04Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-28T12:56:35Z

Build Failed 😭

Build Id: bddc206a-9952-4f27-a889-27b9d0741b62

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-10-28T12:57:29Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-10-28T13:06:51Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-10-28T13:36:56Z

Build Failed 😭

Build Id: f9b11ebe-2b14-4d07-bbcf-71a4bd0d5d32

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch

The Kubernetes version should be at 1.30 (or 1.30.5 if the patch version is used). The client-go can remain at v0.31.

igooch · 2024-10-28T20:25:03Z

build/build-image/Dockerfile

@@ -53,7 +53,7 @@ RUN go install golang.org/x/tools/cmd/goimports@latest && \
 #
 # When this is raised to 1.29: bump the code-generator version on line 66 to the v0.30 tag.
 # When this is raised to >=1.30: delete line 66-67 and uncomment line 68 to stop pinning code-generator.
-ENV KUBERNETES_VER 1.29.7
+ENV KUBERNETES_VER 1.31.0


Kubernetes cluster version should be the middle version, this this case K8s 1.30. The test cluster is currently at patch version 1.30.5 so we should use that one.

Yes, you are correct that the Kubernetes version should be 1.30.5 in the Dockerfile.
But, while executing this step "make gen-embedded-openapi" , I have encountered the following error "--
workdir=/go/src/agones.dev/agones/build/scripts/k8s-export-openapi agones-build:7c4fe85bb7
go run -mod=mod ./main.go
2024/10/30 14:07:30 Failed to start kubectl proxy: fork/exec /usr/local/bin/kubectl: exec format error
exit status 1
make: *** [Makefile:727: gen-embedded-openapi] Error 1"

However, It works fine when I switch the Kubernetes cluster version to 1.31.0 in the above Dockerfile. Could you please guide me on resolving this error to ensure compatibility with version 1.30.5, if version 1.30.5 must be mandatory.

Interesting, for some reason https://storage.googleapis.com/kubernetes-release/release/v1.30.5/bin/linux/amd64/kubectl does not exist. If we use 1.30.4 instead of 1.30.5 for both Kubernetes and Kubectl versions it should work.

Edit: The link for easier to read table of the available Google storage release versions: https://pantheon.corp.google.com/storage/browser/kubernetes-release/release

igooch · 2024-10-28T20:25:34Z

build/build-image/Dockerfile

@@ -53,7 +53,7 @@ RUN go install golang.org/x/tools/cmd/goimports@latest && \
 #
 # When this is raised to 1.29: bump the code-generator version on line 66 to the v0.30 tag.
 # When this is raised to >=1.30: delete line 66-67 and uncomment line 68 to stop pinning code-generator.


Please also follow this comment since we will be at >=1.30.

Be sure to delete lines 53-55 and update lines 66-68 to:

RUN mkdir -p /go/src/k8s.io && cd /go/src/k8s.io && \ git clone -b kubernetes-${KUBERNETES_VER} --depth=3 https://github.com/kubernetes/code-generator.git

github-actions · 2024-11-04T12:25:48Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-11-04T13:32:58Z

Build Failed 😭

Build Id: 3cd5ccc4-3c99-4d3c-9984-6434a43df506

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-11-05T05:10:22Z

Build Succeeded 🥳

Build Id: 8e125d20-dea5-46ce-9b22-917b6bf10e00

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-52548f8
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-52548f8
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-52548f8-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-52548f8
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-52548f8
Linux C++ SDK (build): agonessdk-1.45.0-dev-52548f8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-52548f8.zip

A preview of the website (the last 30 builds are retained):

https://52548f8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4024/head:pr_4024 && git checkout pr_4024
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-52548f8

github-actions · 2024-11-05T17:13:06Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-11-05T18:16:39Z

Build Succeeded 🥳

Build Id: 982362fa-9fcf-4829-862a-98bf41769c7c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-62c481b
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-62c481b
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-62c481b-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-62c481b
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-62c481b
Linux C++ SDK (build): agonessdk-1.45.0-dev-62c481b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-62c481b.zip

A preview of the website (the last 30 builds are retained):

https://62c481b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4024/head:pr_4024 && git checkout pr_4024
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-62c481b

* Update Supported to 1.29, 1.30, 1.31 * nit * regenerate crd docs * revert ID * using 1.30.4 patch version --------- Co-authored-by: Mengye (Max) Gong <8364575+gongmax@users.noreply.github.com>

Update Supported to 1.29, 1.30, 1.31

949eb28

github-actions bot added kind/other size/XL labels Oct 28, 2024

kamaljeeti marked this pull request as ready for review October 28, 2024 11:29

kamaljeeti requested review from gongmax, markmandel and igooch October 28, 2024 11:29

nit

3310757

regenerate crd docs

362a0d4

revert ID

0dffaba

igooch reviewed Oct 28, 2024

View reviewed changes

using 1.30.4 patch version

52548f8

Merge branch 'main' into update-kubernetes-version

62c481b

gongmax approved these changes Nov 5, 2024

View reviewed changes

gongmax merged commit a0d1614 into googleforgames:main Nov 5, 2024
4 checks passed

0xaravindh added the kind/breaking Breaking change label Nov 19, 2024

kamaljeeti deleted the update-kubernetes-version branch March 13, 2025 10:56

Update Supported Kubernetes to 1.29, 1.30, 1.31 #4024

Update Supported Kubernetes to 1.29, 1.30, 1.31 #4024

Uh oh!

Conversation

kamaljeeti commented Oct 28, 2024 • edited by gongmax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

agones-bot commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

agones-bot commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

agones-bot commented Oct 28, 2024

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

igooch Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

kamaljeeti Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igooch Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igooch Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

igooch Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 4, 2024

Uh oh!

agones-bot commented Nov 4, 2024

Uh oh!

agones-bot commented Nov 5, 2024

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

agones-bot commented Nov 5, 2024

Uh oh!

Uh oh!

Uh oh!

kamaljeeti commented Oct 28, 2024 •

edited by gongmax

Loading

kamaljeeti Oct 30, 2024 •

edited

Loading

igooch Oct 31, 2024 •

edited

Loading