Skip to content

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Found that nextCronMinuteBetween would return an invalid crontab of "59-0 * * * *" at minute 59 of the day. Implemented a fix so that it now return "0-1 * * * *" which takes a little bit longer, but no longer errors out.

Also updated test to fail fast rather than let the test continue if this error happens, to aid in debugging in the future.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Found that `nextCronMinuteBetween` would return an invalid crontab
of "59-0 * * * *" at minute 59 of the day. Implemented a fix so that
it now return "0-1 * * * *" which takes a little bit longer, but no
longer errors out.

Also updated test to fail fast rather than let the test continue if this
error happens, to aid in debugging in the future.
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Dec 5, 2024
@markmandel markmandel requested a review from igooch December 5, 2024 20:23
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 5, 2024
@github-actions github-actions bot added the size/S label Dec 5, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 587a6d50-933f-494d-8037-928dd50cf316

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4058/head:pr_4058 && git checkout pr_4058
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-df9a27d

@peterzhongyi peterzhongyi merged commit 5c64044 into googleforgames:main Dec 5, 2024
4 checks passed
@markmandel markmandel deleted the flake/TestScheduleAutoscaler branch December 5, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants