Flake: e2e/TestScheduleAutoscaler #4058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Found that
nextCronMinuteBetween
would return an invalid crontab of "59-0 * * * *" at minute 59 of the day. Implemented a fix so that it now return "0-1 * * * *" which takes a little bit longer, but no longer errors out.Also updated test to fail fast rather than let the test continue if this error happens, to aid in debugging in the future.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A