Skip to content

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

  • Better eviction test
  • Extra test for communication on shutdown
  • Extra test logging and cleanup

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

* Better eviction test
* Extra test for communication on shutdown
* Extra test logging and cleanup
@markmandel markmandel requested a review from igooch April 3, 2025 03:47
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Apr 3, 2025
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 3, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: c16caf0f-b284-4ff8-8024-8f4b36cb1b61

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator Author

Checks passed on re-run. Haven't seen that unit test flake before though I don't think 🤔

@markmandel markmandel requested a review from gongmax April 3, 2025 05:27
@gongmax gongmax merged commit 49193bf into googleforgames:main Apr 3, 2025
4 checks passed
@markmandel markmandel deleted the e2e/test-improvements branch April 5, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants