Skip to content

Conversation

kamaljeeti
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#4140

Closes #4140

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Apr 3, 2025
@kamaljeeti kamaljeeti requested review from gongmax and igooch April 3, 2025 12:36
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7f790a8d-67e1-4627-86c5-0da6ce6b9726

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4144/head:pr_4144 && git checkout pr_4144
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-e40851d

Comment on lines 38 to 40
// FeaturePortPolicyNone is a feature flag to allow setting Port Policy to None.
FeaturePortPolicyNone Feature = "PortPolicyNone"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why reorder this? I think they were ordered alphabetically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll put this after "DisableResyncOnSDKServer" feature.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6ed1fbdf-c6aa-444f-9029-55c5e549fc15

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@kamaljeeti
Copy link
Contributor Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7a6620d1-14f4-42e4-9c36-755146f26a15

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4144/head:pr_4144 && git checkout pr_4144
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-1413e8d

@gongmax gongmax merged commit d07dabd into googleforgames:main Apr 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote PortPolicyNone to Beta
3 participants