-
Notifications
You must be signed in to change notification settings - Fork 858
Promote PortRanges to Beta #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@igooch Do we need to update PortRanges & PortPolicyNone in the versionMap.yaml Dev session? agones/test/upgrade/versionMap.yaml Lines 96 to 98 in d07dabd
|
Build Failed 😭 Build Id: 0198c246-79e4-48df-94e4-35e50323f967 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Failed 😭 Build Id: 8f0d3fa5-2bba-42f9-bd41-f4a39ada2a91 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: 229dce17-0a09-481f-8e01-5ac8ce3ed536 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -33,10 +33,10 @@ The current set of `alpha` and `beta` feature gates: | |||
| [Support Passthrough on GKE Autopilot](https://github.com/googleforgames/agones/issues/3721) | `AutopilotPassthroughPort` | Enabled | `Beta` | 1.43.0 | | |||
| [Support for Extended Duration Pods on GKE Autopilot (*1.28+ only*)](https://github.com/googleforgames/agones/issues/3386) | `GKEAutopilotExtendedDurationPods` | Enabled | `Beta` | 1.44.0 | | |||
| [Port Policy None](https://github.com/googleforgames/agones/issues/3804) | `PortPolicyNone` | Enabled | `Beta` | 1.49.0 | | |||
| [Multiple dynamic port ranges](https://github.com/googleforgames/agones/issues/1911) | `PortRanges` | Enabled | `Beta` | 1.49.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both line 35 and 36 should be behind a release guard. eg https://github.com/googleforgames/agones/pull/4138/files#diff-6a76655b1e397b2f3b9955ebe19b8263aa78cd04aed336f6a737d9e408eac30c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporated
Build Succeeded 🥳 Build Id: e1aec773-6dc6-436c-95f3-2fe977032000 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:#4141
Closes #4141
Special notes for your reviewer: