Skip to content

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Apr 7, 2025

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

For the upgrade tests Agones is installed by a job. This means that all permissions for the Agones install must also exist in the job. This is to cleanup errors in the upgrade test like:

Failed to update lock optimistically: leases.coordination.k8s.io "agones-controller-lock" is forbidden: User "system:serviceaccount:agones-system:agones-controller" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "agones-system", falling back to slow path

that are due to the job not having the permissions in the agones-system namespace. The ServiceAccount names added to the permissions are taken directly from the install.yaml file for agones https://github.com/googleforgames/agones/blob/d07dabd7100c2a14717ec902080b59a2fdc399fe/install/yaml/install.yaml#L17720-L17722.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

@igooch igooch requested a review from gongmax April 7, 2025 18:21
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 7, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 7836c39d-7275-45a6-a914-65b0649a1798

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator Author

igooch commented Apr 7, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 9f0c3f5a-87b5-4d4e-8d73-d369a9f0e879

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator Author

igooch commented Apr 8, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 12a334ef-2ffb-4db7-9f36-7753dcadf448

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4148/head:pr_4148 && git checkout pr_4148
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-cbc4b92

@igooch igooch enabled auto-merge (squash) April 14, 2025 21:58
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0ea9cb8c-b2d9-4905-9da6-d9954647b291

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4148/head:pr_4148 && git checkout pr_4148
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-f86b26f

@igooch igooch merged commit 3281112 into googleforgames:main Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants