Skip to content

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4167

Special notes for your reviewer:

@0xaravindh 0xaravindh requested review from gongmax and igooch May 2, 2025 07:55
@0xaravindh 0xaravindh self-assigned this May 2, 2025
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label May 2, 2025
Copy link

github-actions bot commented May 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@0xaravindh 0xaravindh added the dependencies Pull requests that update a dependency file label May 2, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0c5c1275-713a-407f-8821-9da52d77c105

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ea393144-ab33-4cf7-89cc-f3f1352be290

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented May 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a0cb0305-2b99-42c0-9bf7-d45a2360fa8d

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0b29b5a8-0a86-44ac-8909-d42790ce6419

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4170/head:pr_4170 && git checkout pr_4170
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-f33cd19

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the directions are missing a step, there should be a find examples -type f -name 'go.mod' -execdir go mod tidy \; to update the examples files.

Copy link

github-actions bot commented May 5, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@0xaravindh
Copy link
Member Author

@igooch I added this step to the template to make sure all go.mod files, including the ones in folders like examples/, are cleaned and up to date:

- [ ] At the root directory, run: `find . -name 'go.mod' -not -path '*/\.*' -execdir go mod tidy \;`

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a5e33152-34d3-43bb-a414-9592132c8b0b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented May 5, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

github-actions bot commented May 5, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 59cd77f1-f8d3-4290-ac61-8cf5b7c67531

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8c6791de-4a0f-4fd3-a163-d2d6f962b8ae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4170/head:pr_4170 && git checkout pr_4170
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-0b403aa

@igooch
Copy link
Collaborator

igooch commented May 5, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 04f45457-6f73-4625-a709-4f6c9499adf9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4170/head:pr_4170 && git checkout pr_4170
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-0b403aa

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch merged commit 445d794 into googleforgames:main May 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang 1.23.8 Version and Dependency Upgrades
3 participants