Skip to content

Changed the sidecar requests rate limiter from exponential to a constant one #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 2, 2025
Merged

Changed the sidecar requests rate limiter from exponential to a constant one #4186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6676944
Changed the sidecar requests rate limiter from exponential to a const…
miai10 May 23, 2025
87f4878
Generate install.yaml
miai10 May 26, 2025
6297175
Merge branch 'main' into perf/sidecar-patches
markmandel May 31, 2025
990f698
Merge branch 'main' into perf/sidecar-patches
0xaravindh Jun 16, 2025
32dbde6
Update the helm.md
miai10 Jun 17, 2025
ffffc1f
Using sdkServer instead of sdk for nesting
miai10 Jun 19, 2025
e53de26
Using sdkServer outside of the controller nesting
miai10 Jun 25, 2025
bef214c
Merge branch 'main' into perf/sidecar-patches
igooch Jun 27, 2025
964e3a2
Merge branch 'main' into perf/sidecar-patches
miai10 Jun 30, 2025
c747b0d
Merge remote-tracking branch 'official/main' into perf/sidecar-patches
miai10 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/helm/agones/templates/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ spec:
- name: SIDECAR_RUN_AS_USER
value: "1000"
- name: SIDECAR_REQUESTS_RATE_LIMIT
value: {{ .Values.agones.controller.sdk.requestsRateLimit | quote }}
value: {{ .Values.agones.controller.sdkServer.requestsRateLimit | quote }}
- name: SDK_SERVICE_ACCOUNT
value: {{ .Values.agones.serviceaccount.sdk.name | quote }}
- name: PROMETHEUS_EXPORTER
Expand Down
2 changes: 1 addition & 1 deletion install/helm/agones/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@
"allocationBatchWaitTime": {
"type": "string"
},
"sdk": {
"sdkServer": {
"type": "object",
"properties": {
"requestsRateLimit": {
Expand Down
2 changes: 1 addition & 1 deletion install/helm/agones/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ agones:
failureThreshold: 3
timeoutSeconds: 1
allocationBatchWaitTime: 500ms
sdk:
sdkServer:
requestsRateLimit: 500ms
replicas: 2
pdb:
Expand Down
7 changes: 6 additions & 1 deletion site/content/en/docs/Installation/Install Agones/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,13 @@ The following tables lists the configurable parameters of the Agones chart and t
| `agones.controller.maxDeletionParallelism` | Maximum number of parallelizing deletion calls in GSS | `64` |
| `agones.controller.maxGameServerDeletionsPerBatch` | Maximum number of GameServer deletion calls per batch | `64` |
| `agones.controller.maxPodPendingCount` | Maximum number of pending pods per game server set | `5000` |

{{% feature publishVersion="1.51.0" %}}
| `agones.controller.sdk.requestsRateLimit` | The GameServer sidecar requests rate limit | `500ms` |
### SDK Server

| Parameter | Description | Default |
|----------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------------|
| `agones.controller.sdkServer.requestsRateLimit` | The GameServer sidecar requests rate limit | `500ms` |
{{% /feature %}}

### Ping Service
Expand Down