Helm: Allow users to override automatically calculated GOMAXPROCS

[narqo]

Summary

As raised in #6467 right now users have no way to override the default env variables some components define. This PR improves that.

• Add reusable mimir.lib.containerEnv helper to merge environment variables with proper precedence
• Enable GOMAXPROCS override for distributor, ingester, querier, ruler-querier, and store-gateway components
• Maintain backward compatibility with existing automatic GOMAXPROCS calculations
• Add comprehensive test coverage for override functionality

🤖 Generated with Claude Code

[narqo]

Note for the reviewers, the side effect of the changes is that the components render a default empty env, when there is no environment variables. This is valid; I don't have issues with that.

[baurmatt]

@narqo Can we please get this merged?

[zenador]

🤖 Automated comment

The CHANGELOG has just been cut to prepare for the next release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the operations/helm/charts/mimir-distributed/CHANGELOG.md document. Thanks!

[QuentinBisson]

Thank you for this PR this is great work :)

[narqo]

@dimitarvdimitrov could you have a look at the latest version

[dimitarvdimitrov]

there are 9 more places which define their own env: blocks. Any reason not to use this template there too?

[dimitarvdimitrov]

isn't there an extra +1 in the comment?

[narqo]

No, the formula in the ingester template is request + max(min(request, 6), 3) + 1 (and I think I know the person, who wrote this formula ;))

[narqo]

there are 9 more places which define their own env: blocks. Any reason not to use this template there too?

But you've asked to not touch places that don't have "GOMAXPROCS" (#11983 (comment)). So I've reverted these. Should I put them back? 😬

[dimitarvdimitrov]

there are 9 more places which define their own env: blocks. Any reason not to use this template there too?

But you've asked to not touch places that don't have "GOMAXPROCS" (#11983 (comment)). So I've reverted these. Should I put them back? 😬

oh.. ok uhmmm, let's keep it as-is 🐒

[dimitarvdimitrov]

i haven't reviewed all files because it will take a long time feel free to merge

[narqo]

LOL, these tests were broken 🙈

[Copilot]

Pull Request Overview

This PR implements functionality to allow users to override automatically calculated GOMAXPROCS environment variables in Helm chart deployments. The PR adds infrastructure to merge environment variables with proper precedence, enabling GOMAXPROCS override for distributor, ingester, querier, ruler-querier, and store-gateway components while maintaining backward compatibility.

• Adds reusable mimir.lib.containerEnv helper for merging environment variables with proper precedence
• Standardizes environment variable syntax by removing unnecessary quotes around environment variable names
• Provides comprehensive test coverage demonstrating GOMAXPROCS override functionality

Reviewed Changes

Copilot reviewed 300 out of 399 changed files in this pull request and generated 1 comment.

File	Description
Multiple test-generated YAML files	Generated test outputs showing standardized env variable syntax and new override capabilities
test-gomaxprocs-override-values-generated	New test case demonstrating GOMAXPROCS override functionality with custom values

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}