-
Notifications
You must be signed in to change notification settings - Fork 627
parquet: optimize query sharding by leveraging materialized series hooks #12136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure how hard would be to test this 🤔
There's already a test for sharding, this is just changing the implementation. I do admit the existing tests could be better, but then again so do all our Parquet tests for now |
npazosmendez
added a commit
that referenced
this pull request
Jul 18, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
francoposa
pushed a commit
that referenced
this pull request
Jul 21, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
francoposa
pushed a commit
that referenced
this pull request
Jul 31, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
jesusvazquez
pushed a commit
that referenced
this pull request
Aug 2, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
jesusvazquez
pushed a commit
that referenced
this pull request
Aug 2, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
jesusvazquez
pushed a commit
that referenced
this pull request
Aug 8, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
francoposa
pushed a commit
that referenced
this pull request
Aug 11, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
francoposa
pushed a commit
that referenced
this pull request
Aug 11, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
francoposa
pushed a commit
that referenced
this pull request
Aug 12, 2025
…oks (#12136) Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.