Skip to content

parquet: optimize query sharding by leveraging materialized series hooks #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

npazosmendez
Copy link
Contributor

Leverage this feature prometheus-community/parquet-common#83 to optimize query sharding. Previously we were materializing all chunks and post-filtering them before sending through the wire. Now we can push down this filter to the materializer and avoid loading them entirely.

@npazosmendez npazosmendez added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Jul 18, 2025
@npazosmendez npazosmendez changed the title deps: update parquet-common lo latest parquet: optimize query sharding by leveraging materialized series hooks Jul 18, 2025
@npazosmendez npazosmendez marked this pull request as ready for review July 18, 2025 14:04
@npazosmendez npazosmendez requested review from stevesg and a team as code owners July 18, 2025 14:04
Copy link
Contributor

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure how hard would be to test this 🤔

@npazosmendez
Copy link
Contributor Author

Not sure how hard would be to test this

There's already a test for sharding, this is just changing the implementation. I do admit the existing tests could be better, but then again so do all our Parquet tests for now

@npazosmendez npazosmendez merged commit b4fd97d into parquet-main Jul 18, 2025
32 of 33 checks passed
@npazosmendez npazosmendez deleted the njpm/fix-query-sharding branch July 18, 2025 14:16
npazosmendez added a commit that referenced this pull request Jul 18, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
francoposa pushed a commit that referenced this pull request Jul 21, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
francoposa pushed a commit that referenced this pull request Jul 31, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
jesusvazquez pushed a commit that referenced this pull request Aug 2, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
jesusvazquez pushed a commit that referenced this pull request Aug 2, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
jesusvazquez pushed a commit that referenced this pull request Aug 8, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
francoposa pushed a commit that referenced this pull request Aug 11, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
francoposa pushed a commit that referenced this pull request Aug 11, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
francoposa pushed a commit that referenced this pull request Aug 12, 2025
…oks (#12136)

Leverage this feature
prometheus-community/parquet-common#83 to
optimize query sharding. Previously we were materializing all chunks and
post-filtering them before sending through the wire. Now we can push
down this filter to the materializer and avoid loading them entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-not-needed PRs that don't need a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants