-
Notifications
You must be signed in to change notification settings - Fork 627
helm: Support revisionhistorylimit #12323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
0e45f00
to
ab31194
Compare
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Thank you for the contribution. I don't mind expanding the chart, but I'd like to know the motivation and the problem that you want to solve with that. Specifically,
|
|
Co-authored-by: Vladimir Varankin <vladimir@varank.in>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed a couple of typos in the changes. Please a look at my comments below.
Also, could you add unit-test for the updated value, so we started to track it as part of the charts API. You can check examples in operations/helm/charts/mimir-distributed/ci/offline
(e.g. I think the simplest is to add a new test-
values files).
After adding the test,
- re-build the "golden" files with
make build-helm-tests
- look over the changes in the generated files
- commit the generated files
With that the future changes in the chart will be tested against these generated values.
operations/helm/charts/mimir-distributed/templates/gateway/gateway-dep.yaml
Outdated
Show resolved
Hide resolved
operations/helm/charts/mimir-distributed/templates/nginx/nginx-dep.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks good!
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Ive made a change to use |
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.