Skip to content

helm: Support revisionhistorylimit #12323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link

@DrFaust92 DrFaust92 commented Aug 6, 2025

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 marked this pull request as ready for review August 6, 2025 19:13
@DrFaust92 DrFaust92 requested a review from a team as a code owner August 6, 2025 19:13
@DrFaust92 DrFaust92 force-pushed the revisionhistorylimit branch from 0e45f00 to ab31194 Compare August 6, 2025 19:15
@DrFaust92 DrFaust92 changed the title feat: Support revisionhistorylimit helm: Support revisionhistorylimit Aug 6, 2025
DrFaust92 and others added 3 commits August 6, 2025 15:16
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
@narqo
Copy link
Contributor

narqo commented Aug 7, 2025

Thank you for the contribution. I don't mind expanding the chart, but I'd like to know the motivation and the problem that you want to solve with that. Specifically,

  • why do we set revisionHistoryLimit: 10 to all workloads — this is the current default in Kubernetes, iirc?
  • why would a user want to change the default?

@DrFaust92
Copy link
Author

Thank you for the contribution. I don't mind expanding the chart, but I'd like to know the motivation and the problem that you want to solve with that. Specifically,

  • why do we set revisionHistoryLimit: 10 to all workloads — this is the current default in Kubernetes, iirc?
  • why would a user want to change the default?
  • Yes, the default is 10.
  • Some cluster operators wish (especially with large clusters) to reduce load on etcd (and argocd tracking objects) and reduce this number .You can see this I a common parameter in charts for things like Argo, Prometheus, and bitnami chart.
    So it's not something exotic either

DrFaust92 and others added 2 commits August 8, 2025 09:08
Co-authored-by: Vladimir Varankin <vladimir@varank.in>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 requested a review from narqo August 8, 2025 13:52
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a couple of typos in the changes. Please a look at my comments below.

Also, could you add unit-test for the updated value, so we started to track it as part of the charts API. You can check examples in operations/helm/charts/mimir-distributed/ci/offline (e.g. I think the simplest is to add a new test- values files).

After adding the test,

  1. re-build the "golden" files with make build-helm-tests
  2. look over the changes in the generated files
  3. commit the generated files

With that the future changes in the chart will be tested against these generated values.

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good!

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
Copy link
Author

operations/helm/charts/mimir-distributed/ci/offline

Ive made a change to use with otherwise the make build-helm-tests command causes a huge diff in manifests.
Ive added an example of override, creating a dedicated values files with all options seems very excessive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants