Use IterWithAttributes in the stalePartialBlockLastModifiedTime function if possible

[olegy2008]

What this PR does

This PR updates stalePartialBlockLastModifiedTime function to use IterWithAttributes instead of Iter to reduce the amount of object attributes calls if bucket supports objstore.UpdatedAt IterOptionType.

Which issue(s) this PR fixes or relates to

Fixes #12359

Checklist

• Tests updated.
• Documentation added.
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
• about-versioning.md updated with experimental features.

[CLAassistant]

All committers have signed the CLA.

[olegy2008]

I didn't update any tests, since existing test TestStalePartialBlockLastModifiedTime uses filesystem bucket which supports UpdatedAt option, so the existing test covers the new code.

Please tell if I should add test or update existing one to cover the case when UpdatedAt option is not supported.

[dimitarvdimitrov]

nice, generally looks ok

Please tell if I should add test or update existing one to cover the case when UpdatedAt option is not supported.

is there a way to wrap the buckt implmentation with our own which returns empty SupportedIterOptions?

[andyasp]

Thanks for the PR. Both branches should be unit tested.

[andyasp]

This can be evaluated once upon construction of the blocks cleaner instead of every call. That would also provide a way to unit test both paths even if the test bucket supports this type of listing.

[olegy2008]

Could you elaborate?
Do you want to add a new bool field to a BlocksCleaner struct, something like supportsUpdatedAt, set it in the NewBlocksCleaner function, and then use in the stalePartialBlockLastModifiedTime function?

[olegy2008]

Applied suggestions from the review, updated test to also use a filesystem bucket wrapper which doesn't support UpdatedAt option.