fix(app): move (not copy) models from install tmpdir to destination #8351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant and
hipsterusername
as code owners
github-actions
bot
added
python
psychedelicious
force-pushed
the
psyche/fix/app/mm-move-dont-copy
branch
from
fe5cec5 to
693bba8
Compare
hipsterusername
approved these changes
Jul 29, 2025
It's not clear why we were copying downloaded models to the destination dir instead of moving them. I cannot find a reason for it, and I am able to install single-file and diffusers models just fine with the change. This fixes an issue where model installation requires 2x the model's size (bc we were copying the model over).
psychedelicious
force-pushed
the
psyche/fix/app/mm-move-dont-copy
branch
from
afb1c2e to
62d5977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's not clear why we were copying downloaded models to the destination dir instead of moving them. I cannot find a reason for it, and I am able to install single-file and diffusers models just fine with the change.
This fixes an issue where model installation requires 2x the model's size (bc we were copying the model over).
Related Issues / Discussions
CC @keturn who noticed this in #8268
QA Instructions
Install a diffusers and single-file model. Should work and generation should succeed afterwards.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)