Skip to content

hotfix: allow rendering extra port services #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

hotfix: allow rendering extra port services #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2577d77
hotfix: fix rendering of extra port services
d3adb5 Mar 28, 2025
cc4b192
chore: bump minecraft chart version to 4.26.1
d3adb5 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/minecraft/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: minecraft
version: 4.26.0
version: 4.26.1
appVersion: SeeValues
home: https://minecraft.net/
description: Minecraft server
Expand Down
4 changes: 2 additions & 2 deletions charts/minecraft/templates/extraports-svc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ metadata:
annotations: {{ toYaml .service.annotations | nindent 4 }}
labels:
app: {{ $serviceName }}
chart: {{ template "minecraft.fullname" . }}
chart: {{ template "chart.fullname" $ }}
release: "{{ $.Release.Name }}"
heritage: "{{ $.Release.Service }}"
app.kubernetes.io/name: "{{ $.Chart.Name }}"
app.kubernetes.io/instance: {{ $minecraftFullname }}
app.kubernetes.io/version: {{ template "chart.version" . }}
app.kubernetes.io/version: {{ template "chart.version" $ }}
spec:
{{- if (or (eq .service.type "ClusterIP") (empty .service.type)) }}
type: ClusterIP
Expand Down