-
Notifications
You must be signed in to change notification settings - Fork 21
Deploy archives without publication in CI mode #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (StringUtils.isNotBlank(artifact.getClassifier())) { | ||
extraTokens.put("classifier", artifact.getClassifier()); | ||
} | ||
String artifactPath = IvyPatternHelper.substitute(publisher.getIvyArtifactPattern(), gid, project.getName(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IvyArtifactPattern can be optional/blank. Should we check for that before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getIvyArtifactPattern
returns a default non-blank value if the IvyArtifactPattern is blank:
public String getIvyArtifactPattern() {
String value = getStringValue(IVY_ART_PATTERN);
if (StringUtils.isBlank(value)) {
return LayoutPatterns.M2_PATTERN;
}
return value.trim();
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! consider the following:
- adding tests that cover those cases.
- is this option only available in CI mode? can't we extend it for normal use as well? maybe with a flag if needed
- update README configuration part to include this as a note
|
tests.
CI mode - deploy archives when no publishing extension is applied.
This PR is necessary to upgrade the Gradle plugin to 5+ in the JFrog CLI and in the Jenkins Artifactory plugin.