Skip to content

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 10, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

CI mode - deploy archives when no publishing extension is applied.
This PR is necessary to upgrade the Gradle plugin to 5+ in the JFrog CLI and in the Jenkins Artifactory plugin.

@yahavi yahavi added the improvement Automatically generated release notes label Aug 10, 2023
@yahavi yahavi requested review from eyalbe4 and attiasas August 10, 2023 14:54
@yahavi yahavi self-assigned this Aug 10, 2023
@yahavi yahavi temporarily deployed to frogbot August 10, 2023 14:54 — with GitHub Actions Inactive
@yahavi yahavi added the safe to test Approve running tests on a pull request label Aug 10, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Aug 10, 2023
@github-actions
Copy link

if (StringUtils.isNotBlank(artifact.getClassifier())) {
extraTokens.put("classifier", artifact.getClassifier());
}
String artifactPath = IvyPatternHelper.substitute(publisher.getIvyArtifactPattern(), gid, project.getName(),
Copy link
Contributor

@attiasas attiasas Aug 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IvyArtifactPattern can be optional/blank. Should we check for that before?

Copy link
Member Author

@yahavi yahavi Aug 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getIvyArtifactPattern returns a default non-blank value if the IvyArtifactPattern is blank:

public String getIvyArtifactPattern() {
    String value = getStringValue(IVY_ART_PATTERN);
    if (StringUtils.isBlank(value)) {
        return LayoutPatterns.M2_PATTERN;
    }
    return value.trim();
}

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! consider the following:

  1. adding tests that cover those cases.
  2. is this option only available in CI mode? can't we extend it for normal use as well? maybe with a flag if needed
  3. update README configuration part to include this as a note

@yahavi yahavi added the safe to test Approve running tests on a pull request label Aug 13, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Aug 13, 2023
@yahavi
Copy link
Member Author

yahavi commented Aug 13, 2023

  1. Added ciServerArchivesTest
  2. This shouldn't work in a non-ci mode. We should encourage users to use only Gradle publications.
  3. But there is zero configuration needed. The process is entirely transparent for the user. Also, users of this plugin will not execute the added code.

@yahavi yahavi merged commit c869969 into jfrog:main Aug 13, 2023
@yahavi yahavi deleted the configurations branch August 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants