Potential fix for code scanning alert no. 19: Workflow does not contain permissions #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
javuto
added
cicd
There was a problem hiding this comment.
Pull Request Overview
This PR adds a default permissions block to the GitHub Actions workflow and grants job-specific permissions for pushing Docker images.
- Introduces a root-level
permissionsblock withcontents: read - Defines job-level permissions for
push_docker_images(addspackages: write)
Comments suppressed due to low confidence (1)
.github/workflows/build_and_test_main_merge.yml:146
- [nitpick] The job-level
contents: readpermission is redundant because it’s already granted by the workflow’s default permissions. You can remove this line to avoid duplication.
contents: read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/jmpsec/osctrl/security/code-scanning/19
To fix the issue, we will add a
permissionsblock to the workflow. At the root level, we will set the default permissions tocontents: read, which is sufficient for most CI workflows. For jobs that require additional permissions, such aspush_docker_images, we will define job-specific permissions to grant only the necessary access.Suggested fixes powered by Copilot Autofix. Review carefully before merging.