Fix for cosign format due to multiple tags #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
📦 build
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with cosign format handling when dealing with multiple Docker tags. The change modifies the codesigning workflow to properly parse space-separated tags and digests, and removes the tag-based loop since cosign operates on image digests rather than tags.
- Replaces string iteration with proper array parsing for tags and digests
- Removes the outer tag loop and keeps only the digest-based signing/verification
- Updates IMAGE_NAME construction to exclude the tag suffix
The TAGS array is parsed but never used in the updated logic Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The TAGS array is parsed but never used in the verification logic Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters for
cosigncommand had an incorrect format due to multiple tags.