Skip to content

Rough draft of configuring the plugin based on the Maven plugin configuration #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nrayburn-tech
Copy link

Ref #107.

This is far from complete, but before I did much else with it I wanted to check that it's something the project would be interested in having added.

The way this works is that when you click the Maven sync action within IntelliJ, the Maven plugin configuration is read and synced with the IntelliJ plugin configuration.

Any code pointers are appreciated, but this is a really rough draft at this point and probably not worth spending much time reviewing the actual code.

Copy link
Contributor

deepsource-io bot commented Jul 24, 2025

Here's the code health analysis summary for commits 8c610f8..d048dd6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@jshiell
Copy link
Owner

jshiell commented Jul 29, 2025

Ooo, interesting. There's definitely demand for this, and the implementation seems nice & contained. It's definitely something I'd be open to adding as long as it's covered by test cases.

Thank you!

@nrayburn-tech
Copy link
Author

I think this is roughly feature complete, with the exception of it not having any tests.

I wonder if this should wait until any Checkstyle version can be configured (ideally an outcome of #672). Otherwise, if the Maven project has a Checkstyle version specified that isn't supported then it will fallback to the IntelliJ plugin default.

An alternative to this would be if the Maven project has 10.1.2 configured and the known compatible version is 10.4.5, then we could set the configuration to use 10.4.5 directly.


Testing IntelliJ plugins is not something I've got much experience with, so it'll probably take a while for me to get suitable testing in place.

@nrayburn-tech
Copy link
Author

Hopefully this goes without saying, but please let me know if there's any suggested changes that should be made.

For example, I know using var can be a preference so I don't mind changing it to explicit types. There might also be a better way for users to opt-in to the Maven import functionality. Maybe something to keep in mind is that this should be doable with Gradle as well, although I haven't explored that at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants