Skip to content

Conversation

mgz-dev
Copy link
Contributor

@mgz-dev mgz-dev commented Feb 4, 2024

Actual code changes are minor.

  • Fixed the formatting for indentions to be consistent with the rest of the files in repo.
  • Updated the script to match the other lora scripts and take in --new_conv_rank as an argument.
  • Updated the load and save functions to be more similar to other script as well.

update script to also take a separate conv rank value
@kohya-ss
Copy link
Owner

kohya-ss commented Feb 7, 2024

Thank you! This is very nice! I will merge this sooner when I have time.

@kohya-ss kohya-ss merged commit 738c397 into kohya-ss:dev Feb 24, 2024
@kohya-ss
Copy link
Owner

Thank you again, and sorry for the delay!

nana0304 pushed a commit to nana0304/sd-scripts that referenced this pull request Jun 4, 2025
…r-conv

Resize lora add new rank for conv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants