Support floats?

[skonto]

In the official docs I still see float support: https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/, am I wrong?
I am currently hitting this error:

controller-tools/pkg/crd/schema.go

Line 387 in abcf7d8

// no floats (technically we shouldn't allow int64 or plain int either, but :shrug:).

Error I get is: unsupported type "float32". I expected my field to be parsed and crd to have a field of type number in the yaml format.

[skonto]

/cc @DirectXMan12 , number based fields should be all string? generate-groups.sh allows floats.

[DirectXMan12]

so, it's technically supported, but floats are highly discouraged (and disallowed in official kubernetes APIs) because they won't round-trip properly, can't actually represent certain numbers exactly, etc (all the normal reasons floats are usually not what you want in a program). We recommend using resource.Quantity or int32 for your numeric types, in accordance with the Kubernetes API conventions.

Closing this for now, but if you have a compelling argument, I'm happy to reconsider.

[tothandras]

I think it would be better to support it and have a warning about this in the documentation. There are scenarios where precision is not important and any workaround might be worse.

[DirectXMan12]

it's not just precision -- it's mainly that it doesn't round-trip. Can you provide a concrete example here of a scenario where you want to use float?

[tothandras]

@DirectXMan12 We have an operator managing canary releases (using Istio). The user should be able to provide arbitrary prometheus queries with thresholds (usually a floating number) alongside the built-in metrics (request success rate and request duration).

[DirectXMan12]

I think that's probably a better case for quantity than for a normal float, but I see your point.

[DirectXMan12]

we could also have an "allowDangerousTypes" option too.

[tothandras]

@DirectXMan12 Thank you for considering it! From a UX perspective, by default I would log out a warning with a link to the relevant part of the documentation or a short description, but not fail to build. The allowDangerousTypes option could be used to turn off this warning.

[DirectXMan12]

/kind feature
/priority backlog
/help

[k8s-ci-robot]

@DirectXMan12:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind feature
/priority backlog
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.