Enchance/just portuguese

[lelemm]

Summary by CodeRabbit

• New Features

  • The app now defaults to Brazilian Portuguese, offering a more consistent localization experience.
  • The language settings interface is now accessible only to users with administrator permissions.

• Refactor

  • Enhanced translation management now automatically cleans up incomplete translations and updates error messaging for improved clarity.
  • Updated the source for cloning translation files to a new repository.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the translation processing and language configuration throughout the project. The script that removes untranslated files now references pt-BR.json instead of en.json, with adjusted key and error handling logic. The internationalization setup in the i18n module and preferences loading function now default to Brazilian Portuguese ("pt-BR"). Additionally, the LanguageSettings component is modified to include a permission check that restricts rendering to users with administrator privileges.

Changes

File(s)	Change Summary
packages/desktop-client/bin/…/remove-untranslated-languages packages/desktop-client/src/i18n.ts packages/loot-core/src/…/prefs.ts	Replaced English language references with Brazilian Portuguese ("pt-BR"), updated file paths, error messages, default language fallback, and thresholds for key comparisons.
packages/desktop-client/src/…/LanguageSettings.tsx	Introduced a permission check via the useAuth hook to conditionally render the language settings component for users with the ADMINISTRATOR role.
bin/package-browser	Updated the repository URL for cloning translation files from https://github.com/actualbudget/translations to https://github.com/lagoom-br/translations.git.

Sequence Diagram(s)

sequenceDiagram
    participant S as Script
    participant D as Translations Dir
    participant F as JSON File
    S->>D: Check for pt-BR.json existence
    D-->>S: Confirm pt-BR.json found
    S->>S: Count keys in pt-BR.json
    loop For each JSON file in directory
        S->>F: Read file and count keys
        alt File ≠ pt-BR.json AND keys < 50% of pt-BR
            S->>D: Delete file
        else
            S->>S: Retain file
        end
    end

Loading

sequenceDiagram
    participant LS as LanguageSettings Component
    participant Auth as useAuth Hook
    LS->>Auth: Request hasPermission('ADMINISTRATOR')
    Auth-->>LS: Return permission status
    alt Permission granted
        LS->>LS: Render language settings interface
    else Permission denied
        LS->>LS: Render empty fragment
    end

Loading

Poem

I'm a rabbit, hopping in delight,
pt-BR now guides our code so bright.
Skipping files with a careful glance,
Admin checks give settings a chance.
With JSON keys and changes so true,
I celebrate these updates—hip, hop, woo!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46848c2 and 74a604a.

📒 Files selected for processing (3)

• bin/package-browser (1 hunks)
• packages/desktop-client/src/components/settings/LanguageSettings.tsx (3 hunks)
• packages/desktop-client/src/i18n.ts (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🔭 Outside diff range comments (2)

packages/desktop-client/bin/remove-untranslated-languages (1)

30-48: Remove dead code.

This code block is unreachable due to the return statement on line 28.

Remove the dead code block to improve maintainability.

packages/desktop-client/src/i18n.ts (1)

26-26: Update the default language in i18n initialization.

The i18n initialization still uses 'en' as the default language, which is inconsistent with the changes to use 'pt-BR' as the default.

Apply this diff to fix the inconsistency:

-    lng: 'en',
+    lng: 'pt-BR',

🧹 Nitpick comments (2)

packages/desktop-client/src/i18n.ts (1)

49-52: Update the outdated comment.

The comment refers to English being always available, but the code now uses Brazilian Portuguese as the default language.

Apply this diff to fix the comment:

-      // English is always available since we use natural-language keys.
+      // Brazilian Portuguese is always available since it's our default language.

packages/desktop-client/src/components/settings/LanguageSettings.tsx (1)

88-88: Fix empty fragment formatting.

The empty fragment doesn't follow the formatting rules.

Apply this diff to fix the formatting:

-  ) : <></>;
+  ) : (
+    <></>
+  );

🧰 Tools

🪛 ESLint

[error] 88-88: Replace <></> with (⏎····<></>⏎··)

(prettier/prettier)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f1fadb and 46848c2.

📒 Files selected for processing (4)

• packages/desktop-client/bin/remove-untranslated-languages (1 hunks)
• packages/desktop-client/src/components/settings/LanguageSettings.tsx (3 hunks)
• packages/desktop-client/src/i18n.ts (2 hunks)
• packages/loot-core/src/client/actions/prefs.ts (1 hunks)

🧰 Additional context used

🪛 ESLint

packages/desktop-client/src/components/settings/LanguageSettings.tsx

[error] 88-88: Replace <></> with (⏎····<></>⏎··)

(prettier/prettier)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: compare

🔇 Additional comments (1)

packages/desktop-client/src/components/settings/LanguageSettings.tsx (1)

36-36: Consider the UX impact of restricting language settings.

Restricting language settings to administrators might negatively impact non-admin users who need to use the application in their preferred language.

Consider:

1. Should language preferences be a personal setting rather than an admin-only feature?
2. How will non-admin users handle language preferences?

Also applies to: 88-88

[coderabbitai]

⚠️ Potential issue

Review the aggressive file deletion logic.

The current implementation unconditionally deletes all JSON files except pt-BR.json. This seems overly aggressive and contradicts the internationalization support shown in other files. Consider keeping the original logic that checks for translation completeness.

Apply this diff to restore the translation completeness check:

-      if (file === 'pt-BR.json' || path.extname(file) !== '.json') return;
-
-      const filePath = path.join(localRepoPath, file);
-      fs.unlinkSync(filePath);
-      return;
+      if (file === 'pt-BR.json' || path.extname(file) !== '.json') {
+        return;
+      }
+
+      const filePath = path.join(localRepoPath, file);
+      const jsonData = JSON.parse(fs.readFileSync(filePath, 'utf8'));
+      const fileKeysCount = Object.keys(jsonData).length;
+
+      // Calculate the percentage of keys present compared to pt-BR.json
+      const percentage = (fileKeysCount / enKeysCount) * 100;
+      console.log(`${file} has ${fileKeysCount} keys (${percentage.toFixed(2)}%).`);
+
+      if (percentage < 50) {
+        fs.unlinkSync(filePath);
+        console.log(`Deleted ${file} due to insufficient keys.`);
+      } else {
+        console.log(`Keeping ${file}.`);
+      }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	files.forEach((file) => {
	if (file === 'en.json' || path.extname(file) !== '.json') return;
	if (file === 'pt-BR.json' || path.extname(file) !== '.json') return;
	const filePath = path.join(localRepoPath, file);
	fs.unlinkSync(filePath);
	return;
	files.forEach((file) => {
	- if (file === 'pt-BR.json' || path.extname(file) !== '.json') return;
	-
	- const filePath = path.join(localRepoPath, file);
	- fs.unlinkSync(filePath);
	- return;
	+ if (file === 'pt-BR.json' || path.extname(file) !== '.json') {
	+ return;
	+ }
	+
	+ const filePath = path.join(localRepoPath, file);
	+ const jsonData = JSON.parse(fs.readFileSync(filePath, 'utf8'));
	+ const fileKeysCount = Object.keys(jsonData).length;
	+
	+ // Calculate the percentage of keys present compared to pt-BR.json
	+ const percentage = (fileKeysCount / enKeysCount) * 100;
	+ console.log(`${file} has ${fileKeysCount} keys (${percentage.toFixed(2)}%).`);
	+
	+ if (percentage < 50) {
	+ fs.unlinkSync(filePath);
	+ console.log(`Deleted ${file} due to insufficient keys.`);
	+ } else {
	+ console.log(`Keeping ${file}.`);
	+ }
	});

[coderabbitai]

⚠️ Potential issue

Reconsider hardcoding the language.

Hardcoding the language to 'pt-BR' removes user language preference support. This change forces all users to use Brazilian Portuguese, ignoring their preferences in globalPrefs.language.

Consider restoring user language preference support:

-    setI18NextLanguage('pt-BR');
+    setI18NextLanguage(globalPrefs.language);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	setI18NextLanguage('pt-BR');
	setI18NextLanguage(globalPrefs.language);