Skip to content

Governement type filter fixes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2025
Merged

Governement type filter fixes #62

merged 4 commits into from
Jan 15, 2025

Conversation

MartijnBogaert
Copy link
Collaborator

@MartijnBogaert MartijnBogaert commented Jan 14, 2025 •
edited
Loading

OPH-447
OPH-449

Corresponding PR app: lblod/app-openproceshuis#43

The following bugfixes/improvements concerning the government type filter were implemented:

  • Strictly interpret selected government type (e.g. don't show "Autonoom gemeentebedrijf" when "Gemeente" is selected).
  • Clear filter when "clear all filters" button is clicked.
  • Only present government types for which processes exist.

An extra bug was fixed concerning the process steps type filter:

  • Clear filter when "clear all filters" button is clicked.

@MartijnBogaert MartijnBogaert added the bug Something isn't working label Jan 14, 2025
@MartijnBogaert MartijnBogaert mentioned this pull request Jan 14, 2025
Merged
@MartijnBogaert MartijnBogaert merged commit 0afb907 into development Jan 15, 2025
3 checks passed
@MartijnBogaert MartijnBogaert deleted the feature/filter-government-types-fixes branch January 15, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbittich nbittich nbittich approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartijnBogaert @nbittich