Skip to content

Add administrative divisions and subdivisions. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 29, 2023
Merged

Add administrative divisions and subdivisions. #8

merged 7 commits into from
Nov 29, 2023

Conversation

lutangar
Copy link
Owner

@lutangar lutangar commented Nov 29, 2023 •
edited
Loading

fix #2 and supersede #7

@lutangar lutangar requested a review from tobika November 29, 2023 13:22
tobika
tobika approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@tobika tobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the informative exchange IRL about the PR that sparked some other improvement ideas that we can address in new issues.
This PR is ready for merge in my opinion.

@lutangar lutangar merged commit 0262865 into master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobika tobika tobika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add state/region to differentiate cities with similar names
2 participants
@lutangar @tobika