-
Notifications
You must be signed in to change notification settings - Fork 120
Add example MP-compatible phase diagram tutorial #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -15,7 +15,14 @@ | |||
from pymatgen.util.coord import find_in_coord_list_pbc | |||
|
|||
import atomate2.vasp.jobs.base | |||
import atomate2.vasp.jobs.defect | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Should have fixed this a long time ago..
tests/forcefields/flows/test_eos.py
Outdated
@@ -2,6 +2,7 @@ | |||
from jobflow import run_locally | |||
from monty.serialization import loadfn | |||
|
|||
from atomate2.common.utils import get_job_uuid_name_map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rather in utils.testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - moved / made a common testing utils file
@esoteric-ephemera that's great. Thanks. |
That makes sense, I'll see if it's possible to trim the new test data down sufficiently |
@JaGeo , @utf : I got the test data for this down to about 10MB so I'm adding it here. I also added convenience classes to make json-format archives of VASP calculations ( So from the user's side, to make VASP test data archive, they have to run two lines of code: from atomate2.utils.testing.vasp import VaspTestData
vtd = VaspTestData.from_directory("calculation directory")
vtd.to_file("name of the json.gz or json.bz2 file")
Hoping this helps with file bloat / size as we grow tests out. If you want me to re-/move this, just let me know |
Great @esoteric-ephemera . I like it. I am fine with leaving it. |
Thank you for the great work. I will merge! |
It came up during the CECAM atomate2 workshop that it would be useful to have an example of how to perform MP-compatible workflow calcs, including how to apply corrections to these.
This adds a notebook to the tutorials on how to do this and a reference set of task docs. To handle the larger amount of raw VASP data used, I've added a
VaspTestData
class toatomate2.utils.testing.vasp
which takes an input calculation directory and handles creation of a compressed JSON archive of the files for better organization / data usageAlso added a utility function for extracting job UUID : name mappings from generic flows with replacements/etc. Can remove if requested, it's been useful for analyzing tests with complex flows when run locally.
Other changes:
strict-openff
dependencies - this keeps breaking tests