feat: Elastic verifier, that allows owner to set multiple VKs #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-zk
changed the title
| @@ -191,7 +191,7 @@ contract GatewayCTMDeployer { | |||
| _isZKsyncOS: _config.isZKsyncOS, | |||
| _deployedContracts: contracts | |||
| }); | |||
| _deployVerifier(salt, _config.testnetVerifier, contracts); | |||
| _deployVerifier(salt, _config.testnetVerifier, contracts, _config.aliasedGovernanceAddress); | |||
There was a problem hiding this comment.
you provide the aliased address of the main governance.
however, this file is now used only locally so what is provided there does not really matter
There was a problem hiding this comment.
yes, do we have any place in the config where we have CTM owner?
| @@ -104,16 +125,25 @@ contract DualVerifier is IVerifier { | |||
| /// @inheritdoc IVerifier | |||
| /// @dev Used for backward compatibility with older Verifier implementation. Returns PLONK verification key hash. | |||
| function verificationKeyHash() external view returns (bytes32) { | |||
| return PLONK_VERIFIER.verificationKeyHash(); | |||
| return plonkVerifiers[0].verificationKeyHash(); | |||
There was a problem hiding this comment.
always 0, is it intended?
There was a problem hiding this comment.
yeah, I wanted it to return a 'default' verification key hash...
…_elastic_verifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple verifiers (VKs) in a single dual verifier.
This will allow us to iterate quickly in stage & testnets with the new zkos system.
Admin will be able to add/remove verifiers based off their Ids.