-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(zk_toolbox): Redesign zk_toolbox commands #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 48 commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
b9f87c4
refactor: add `zks` as `zki dev` subcommand
manuelmauro 827e281
style: format code
manuelmauro 4585320
style: format imports
manuelmauro 8e03c16
refactor: use `zki dev` instead of `zks` in CI
manuelmauro 3c9ff94
refactor: remove zk_supervisor crate
manuelmauro ab7d584
fix: remove occurences of zks in dev and installation scripts
manuelmauro 2d02e41
fix: remove unused flags in zkup
manuelmauro 0394cac
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro a2c36ff
fix: allor to run benchmarks on main branch after zks will be removed
manuelmauro dde2fc1
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 5f04a79
style: format code
manuelmauro c51dd69
refactor: rename zk_inception to zkstack
manuelmauro 805515c
style: format code
manuelmauro 5e2de69
docs: fix zk_supervisor occurences in docs
manuelmauro fa0c34c
refactor: remove occurences of zk_toolbox
manuelmauro f41b59c
refactor: replace ZkInception with ZkStack
manuelmauro 07373fa
style: format code
manuelmauro 89d92d9
refactor: remove some more occurences of toolbox wording
manuelmauro 52c1ca7
refactor: rename zkup to zkstackup
manuelmauro 1456d03
refactor: rename ZkToolboxConfig to ZkStackConfig
manuelmauro 664aed4
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 240636a
refactor: remove last occurences of the wording "toolbox"
manuelmauro b3fd67a
refactor: update ascii art banner
manuelmauro ad06223
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 0770782
fix: remove unsupported flag --alias
manuelmauro 1b7d110
refactor: remove occurences of old ZK supervisor wording
manuelmauro a0d0eae
docs: use new ZK Stack CLI wording in docs
manuelmauro 15aecf7
docs: remove occurences of zks alias from docs
manuelmauro d84ad52
feat: fallback to zk_supervisor in case zkstack is not installed
manuelmauro 2f73330
docs: change deprecation message to include zkup
manuelmauro eb3d7b4
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro a86cf29
feat: remove zkt
manuelmauro bdb1e13
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro f15d3a9
fix: invoke zkstackup using its relative path
manuelmauro 8b448e6
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 45e639f
fix: install zkstackup in CI before invoking zkstack
manuelmauro 4f3cde5
fix: typo in zkstackup installation command
manuelmauro ae868d1
fix: fix more typos
manuelmauro c556a3f
fix: source /root/.bashrc before invoking zkstackup
manuelmauro 04d6bbe
fix: invoke zkstackup using its relative path
manuelmauro 341e2a9
fix: invoke zkstack with its relative path
manuelmauro 704e854
feat: install zkstack in $HOME/.local/bin
manuelmauro 4423428
feat: use $HOME/.local in zkstackup
manuelmauro 5286e90
refactor: improve CI steps subdivision
manuelmauro 605fdd8
feat: add bin folder to path in zkstackup
manuelmauro 3ac3a05
docs: improve zkstack installation messages
manuelmauro 783cffa
fix: add more folders to GITHUB_PATH
manuelmauro 4e3ec09
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 89f1638
fix: invoke zkstackup using its relative path
manuelmauro 0894726
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 94235c4
Revert "fix: invoke zkstackup using its relative path"
manuelmauro 9d982ab
fix: add zkstack and zkstackup to PATH in containers
manuelmauro 8c3b92e
fix: fix typo in PATH export
manuelmauro 9408ea8
fix: use relative path for zkstackup in Makefile
manuelmauro 6f6f328
fix: add zkstackup to containers PATH
manuelmauro 7bd7520
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 77b4603
fix: add zkstackup to PATH in makefile
manuelmauro e5149d3
fix: use relative paths to zkstackup in workflow templates
manuelmauro 20bbc0b
fix: fix relative invoations of zkstackup in CI
manuelmauro 88d2229
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 67a446f
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
Deniallugo c33cdcf
chore: update sqruff-lib to 0.19.0
manuelmauro 7427509
chore: use published version for sqruff-lib
manuelmauro 884c2fd
ci: use relative invocations of zkstackup in all CI jobs
manuelmauro 3afee03
fix: temporarily invoke zkstack using its absolute path
manuelmauro 0ad41b8
chore: update Cargo.lock
manuelmauro 67ee796
fix: add executable permissions to zkstack bin
manuelmauro 975b189
refactor: rely on PATH for zkstack invocation
manuelmauro 801775c
refactor: use zkstackup instead of zkt
manuelmauro 92f8079
style: add EOF newline
manuelmauro 87a19b4
Revert "refactor: rely on PATH for zkstack invocation"
manuelmauro b15d688
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 7516cd1
style: add EOF newline
manuelmauro 1ac7c63
refactor: deduplicate format prompts in pre-push
manuelmauro 27f7de2
fix: add back deleted command
manuelmauro d11e4c4
Revert "fix: add back deleted command"
manuelmauro 5c76625
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 603e9ff
refactor: rely on PATH for zkstack invocation in CI
manuelmauro 15f5f42
test: print PATH
manuelmauro 8d8110c
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro b517a46
Revert "refactor: rely on PATH for zkstack invocation in CI"
manuelmauro fde4703
test: print PATH in CI
manuelmauro 5673190
test: print PATH again
manuelmauro 00279d2
fix: add /root/.local/bin to GITHUB_ENV
manuelmauro fb07e36
refactor: rely on PATH for zkstack invocation
manuelmauro c772f54
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 7adf3b9
Revert "refactor: rely on PATH for zkstack invocation"
manuelmauro 65e2f88
Revert "Revert "refactor: rely on PATH for zkstack invocation""
manuelmauro 2696f90
refactor: try installing zkstack in /usr/local
manuelmauro ed4be01
fix: typo in LOCAL_DIR
manuelmauro 008a7d9
feat: add global installation option for zkstackup and zkstack
manuelmauro 3fadff4
refactor: remove /root/.local/bin from GITHUB_PATH
manuelmauro c47e520
fix: update BIN_DIR on -g flag
manuelmauro 4436a8c
fix: removed --local flag from zkstackup invocations
manuelmauro 28dfeb2
fix: add missing --path options to zkstackup invocations
manuelmauro 699f476
fix: one more missing --path option
manuelmauro f6e7037
fix: missing ;; in --global option parsing
manuelmauro 40bc139
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 08b1232
refactor: lint code
manuelmauro 6eb730c
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro edf1e07
fix: correctly invoke zkstackup in CI
manuelmauro 9622e34
fix: use ZKSYNC_HOME instead of relative path
manuelmauro a283d8b
fix: use sudo for global installation
manuelmauro 0c94073
Revert "fix: use sudo for global installation"
manuelmauro 5a65009
fix: install zkstack locally
manuelmauro 3eb7a0a
fix: use local installation of zkstack
manuelmauro 4c56f4f
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro e04d7ee
test: test zkstackup install script in CI
manuelmauro 2dafd48
fix: use relative path instead of ZKSYNC_HOME
manuelmauro 7b37fcb
fix: update BIN_PATH variable when --global option is submitted
manuelmauro 96c6ae2
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro f13106f
fix: fix global installation for zkstackup
manuelmauro a3a0d4c
fix: fix relative path invocation of install script
manuelmauro 14c4c1a
refactor: remove zkstackup folder from GITHUB_PATH
manuelmauro cd2ebe4
fix: keep a bunch of zkstackup in GITHUB_PATH
manuelmauro 28f1314
feat: configure githooks in zk
manuelmauro 989a0ad
refactor: minimize use of zkstackup in GITHUB_PATH
manuelmauro 9173320
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro 51a85ad
refactor: configure git hooks in zkstackup
manuelmauro 5dbb2d2
fix: setup hooks only if inside a git repo
manuelmauro 211c048
docs: add TODO for code that must be removed in a future PR
manuelmauro 3548fd3
fix: restore contracts submodule
manuelmauro e8c1d14
Merge branch 'main' into manuel-redesign-zk-toolbox-commands
manuelmauro dfc9349
docs: suggest the use of zkstackup for zkstack installation
manuelmauro c7cbfa5
feat: add --local alias for --path ./
manuelmauro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"core": "24.28.0", | ||
"prover": "16.5.0", | ||
"zk_toolbox": "0.1.2" | ||
} | ||
"zkstack_cli": "0.1.2" | ||
} | ||
manuelmauro marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.